Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work on Chrome 72 #16

Closed
wtetsu opened this issue Dec 27, 2018 · 2 comments
Closed

Doesn't work on Chrome 72 #16

wtetsu opened this issue Dec 27, 2018 · 2 comments
Assignees
@wtetsu
Labels
bug

Comments

@wtetsu
Copy link
Owner

wtetsu commented Dec 27, 2018 •
edited
Loading

Maybe due to some problems with storage functionalities.

Reporter:
https://twitter.com/Yuichiro_S/status/1078235803887722497

options.js:36874 Uncaught (in promise) TypeError: Illegal invocation: Function must be called on an object of type StorageArea
    at Promise (options.js:36874)
    at new Promise (<anonymous>)
    at doAsync (options.js:36863)
    at Object.get (options.js:36835)
    at Object.pickOut (options.js:36843)
    at Main._callee$ (options.js:38835)
    at tryCatch (options.js:199)
    at Generator.invoke [as _invoke] (options.js:426)
    at Generator.prototype.(anonymous function) [as next] (chrome-extension://dojehnlfnmmhkgahnfnjeeemhleflhfc/options/options.js:252:21)
    at asyncGeneratorStep (options.js:38662)
@wtetsu wtetsu added the bug label Dec 27, 2018
@wtetsu wtetsu self-assigned this Dec 27, 2018
wtetsu added a commit that referenced this issue Dec 27, 2018
@wtetsu
Merge branch 'fix/promise_bug_chrome72' #16
9d888a9
@wtetsu
Copy link
Owner Author

wtetsu commented Dec 27, 2018

Fixed in 1.1.8

@wtetsu wtetsu closed this as completed Dec 28, 2018
@moderndeveloperllc moderndeveloperllc mentioned this issue Jan 30, 2019
Closed
@maciejsszmigiero maciejsszmigiero mentioned this issue Mar 8, 2019
Merged
@wtetsu
Copy link
Owner Author

wtetsu commented Mar 9, 2019 •
edited
Loading

Memo:
I made sure this error didn't happen when Chrome was v71. When this issue was reported and I fixed it, Chrome v72 was Beta version yet(72.0.3626.28).

See also: 9d888a9#commitcomment-32663941

(Since this issue is referred from several repositories I added this memo)

zoracon pushed a commit to EFForg/https-everywhere that referenced this issue Apr 11, 2019
@maciejsszmigiero @zoracon
Fix Chromium local store exception (#17557)
146032c 
At least on Chromium 73 when opening the extension options window an
exception
"TypeError: Illegal invocation: Function must be called on an object of type StorageArea"
is thrown, which results in empty update channels page.

It looks like chrome.storage.local methods need to be called while bound to
the chrome.storage.local object.

According to
KeithHenry/chromeExtensionAsync#10
wtetsu/mouse-dictionary#16 this Chromium change
has been introduced probably around version 70 or 72.

Automatic ruleset updates might have been affected by this, too.
wtetsu added a commit that referenced this issue Jun 26, 2019
@wtetsu
Make storage.js great again
9900cef 
See also: #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wtetsu wtetsu

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wtetsu