Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CmdRunner keeps spawning new processes #1225

Closed
myyra opened this issue Apr 21, 2022 · 3 comments
Closed

CmdRunner keeps spawning new processes #1225

myyra opened this issue Apr 21, 2022 · 3 comments
Labels
🐛 bug "Houston, we've had a problem." 👍 confirmed

Comments

@myyra
Copy link

myyra commented Apr 21, 2022

CmdRunner with the pseudo-terminal mode keeps spawning new processes and leaving the old ones hanging around. This has made me hit the process limit multiple times.

wtftuil 0.41.0, macOS 12.0.1 arm64

@igbanam
Copy link
Contributor

igbanam commented Apr 22, 2022

Could you add some more information around "pseudo-terminal", please? …for repro purposes.

  • What emulator are you using?
  • What shell?
  • Is this behind TMux?

@myyra
Copy link
Author

myyra commented Apr 22, 2022

By pseudo-terminal, I mean the pty option in the CmdRunner module. Setting pty: true causes the processes to hang around forever. Setting it to false resolves it.

I don't think that's terminal-specific, but I'm using iTerm2 3.4.14 with Bash 5.1.16, no TMux.

@myyra
Copy link
Author

myyra commented Apr 22, 2022

I thought it's because the PTY is never closed in here, even though https://github.com/creack/pty says it should be.

BUT after quickly adding defer func() { _ = f.Close() }() there, the commands are still not cleared.

@senorprogrammer senorprogrammer added the 💪 improvement "Where we're going, we don't need roads." label Jun 19, 2022
Seanstoppable added a commit to Seanstoppable/wtf that referenced this issue Aug 23, 2022
Seanstoppable added a commit to Seanstoppable/wtf that referenced this issue Aug 23, 2022
@Seanstoppable Seanstoppable added 🐛 bug "Houston, we've had a problem." 👍 confirmed and removed 💪 improvement "Where we're going, we don't need roads." labels Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug "Houston, we've had a problem." 👍 confirmed
Development

No branches or pull requests

4 participants