Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type issue with ButtonGroup children #1705

Closed
Calvein opened this issue Nov 17, 2022 · 2 comments · Fixed by #2025
Closed

Type issue with ButtonGroup children #1705

Calvein opened this issue Nov 17, 2022 · 2 comments · Fixed by #2025
Labels
bug Something isn't working

Comments

@Calvein
Copy link
Contributor

Calvein commented Nov 17, 2022

😭 Bug report

Describe the bug

ButtonGroup children should accept null | false | undefined (only after react 18)
@Calvein Calvein added the bug Something isn't working label Nov 17, 2022
@theo-mesnil
Copy link
Contributor

@Calvein what is the current status of this issue ?

@Calvein
Copy link
Contributor Author

Calvein commented Mar 22, 2023

Still an issue, I'm making a fix

@theo-mesnil theo-mesnil linked a pull request Mar 22, 2023 that will close this issue
Allow falsy children in <ButtonGroup>, fixes #1705 #2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
Welcome UI - Project board
Status: RELEASED
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow falsy children in <ButtonGroup>, fixes #1705 WTTJ/welcome-ui
2 participants
@Calvein @theo-mesnil