Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the '@octokit/rest' import statement #61

Merged
merged 4 commits into from
Feb 5, 2020

Conversation

damingerdai
Copy link
Contributor

Purpose | 本PR解决的问题

Changes | 本PR的更改

  • fix: change the '@octokit/rest' import statement
  • ci: ignore yarn error log
  • ci: imporve the pre commit git hooks

Checklist | 检查

  • Are tests written for added code? | 新增代码是否添加测试用例
  • Yes
  • No because: No
  • Did you introduce any new dependencies? | 如果添加新的依赖,请列出依赖并说明添加该依赖的原因
  • No
  • Yes
    • Dependency:
    • Reason:

@menbotics menbotics bot added the kind/bug Category issues or prs related to bug. label Feb 4, 2020
@damingerdai
Copy link
Contributor Author

在我本地这个pr是可以跑通

@codecov-io
Copy link

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   28.37%   28.37%           
=======================================
  Files          18       18           
  Lines         430      430           
  Branches       23       23           
=======================================
  Hits          122      122           
  Misses        308      308
Impacted Files Coverage Δ
app/service/github.ts 26.31% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eea06ba...9d55b36. Read the comment docs.

@damingerdai
Copy link
Contributor Author

node8已经不再支持,应该早日升级到10(12 better)

Copy link
Contributor

@frank-zsy frank-zsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@menbotics menbotics bot added the pull/approved If a pull is approved, it will be automatically merged label Feb 5, 2020
@menbotics menbotics bot merged commit ee8c914 into wuhan2020:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug. pull/approved If a pull is approved, it will be automatically merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: '@octokit/rest'引入方式有误
3 participants