#318 Add ESLint support and configure it to use Drupal standards. #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tormi
reviewed
Oct 31, 2022
.lando.yml
Outdated
| build_as_root: | ||
| # To be able to run ESLint with GrumPHP, we need Node.js on appserver. | ||
| - "apt-get update" | ||
| - "apt-get install -y nodejs" |
There was a problem hiding this comment.
I would avoid such things in a template - they slow down the build time. Perhaps we should consider using custom PHP images instead with nodejs included?
tormi
reviewed
Nov 1, 2022
| @@ -1,3 +1,2761 @@ | |||
| { | |||
| "lockfileVersion": 2 | |||
| "name": "wunderio-drupal-project", | |||
| @@ -23,6 +23,9 @@ grumphp: | |||
| # PHPUnit will fail with 0 tests. | |||
| phpunit: | |||
| testsuite: unit | |||
| eslint: | |||
There was a problem hiding this comment.
Let's consider other options as well like using Husky via node service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test:
git clone git@github.com:wunderio/drupal-project.gitcd drupal-projectgit checkout feature/#318-Add-ESLint-support-and-configure-it-to-use-Drupal-standardslando start(orlando rebuildif you've working on existing Lando project)echo 'var foo="bar"' > web/modules/custom/phpunit_example/example.jsgit add web/modules/custom/phpunit_example/example.jsgit commitThere's also an alternative PR here #320 that uses node service but it's currently proof of work. It breaks Code Quality scans, you need to configure name and e-mail in the node service.