php-fpm: elasticdump for importing/exporting Elasticsearch data #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jancis
force-pushed
the
feature/elasticdump
branch
from
09af540
to
ccd227e
Compare
This was referenced Mar 26, 2024
Rade333
requested changes
Apr 29, 2024
| @@ -119,6 +119,9 @@ COPY config/w-php-defaults.ini /usr/local/etc/php/conf.d/w-php-defaults.ini | |||
| COPY silta /silta | |||
| COPY silta/entrypoints/10-env.sh /etc/profile.d/10-env.sh | |||
|
|
|||
| # Elasticdump for importing/exporting Elasticsearch data | |||
| RUN apk add npm nodejs && npm install -g elasticdump | |||
There was a problem hiding this comment.
Please move this line a bit further up, above lines 95-96 which do cleanup. Also, add && npm cache clean --force after the npm install command.
There was a problem hiding this comment.
Update after my review on #182: #182 (review)
I realized npm can be removed after elasticdump is installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds elasticdump binary for importing/exporting Elasticsearch data