-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix glitchy mousewheel scrolling #11
base: main
Are you sure you want to change the base?
Conversation
@xiota I tested this, but this produce weird behaviour on my machine, one scroll mouse wheel will scroll 2 lines? |
On my computer, as far as I can tell, this works properly. Only one line at a time. How does the Textual demo work on your computer? (On my computer, the demo runs with |
Tried it, indeed textual demo is also behaving weird. Seems like issue with my os setup or broken mouse/trackpad. Let me try it on other machine. |
I'm using Textual v0.27.0. Looks like baca reqs specify Textual v0.16.0. Glitchy scroll behavior seems to result from some change in Textual v0.17.0. |
@xiota maybe we should raise this glitchy issue to textual? |
I agree. I'll check to make sure it isn't already reported. If it isn't, I'll open a new issue and @ you so you can add info about the 2-line scrolling. |
@xiota Thanks, mate. No worries about 2 line scroll tho, I think it has to do with signal being passed to parent widget, so the app and screen get scrolled then produces 2 line scroll. Might be also textual issue, but let me look at it for a while. |
a0f7f33
to
cb944e9
Compare
Did not get around to opening an issue upstream, but this seems to be a definite API change in 0.17.0 (2023-03-29) because the upstream examples were modified. Force pushed to sync with main. Changed textual requirement to >=0.17.0 <1.0.0. Manually edited Note: I'm adding the changes for |
Closes #10