Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glitchy mousewheel scrolling #11

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

xiota
Copy link
Contributor

@xiota xiota commented Jun 4, 2023

Closes #10

@wustho
Copy link
Owner

wustho commented Jun 7, 2023

@xiota I tested this, but this produce weird behaviour on my machine, one scroll mouse wheel will scroll 2 lines?

@xiota
Copy link
Contributor Author

xiota commented Jun 7, 2023

one scroll mouse wheel will scroll 2 lines?

On my computer, as far as I can tell, this works properly. Only one line at a time. How does the Textual demo work on your computer? (On my computer, the demo runs with python -m textual.)

@wustho
Copy link
Owner

wustho commented Jun 7, 2023

one scroll mouse wheel will scroll 2 lines?

On my computer, as far as I can tell, this works properly. Only one line at a time. How does the Textual demo work on your computer? (On my computer, the demo runs with python -m textual.)

Tried it, indeed textual demo is also behaving weird. Seems like issue with my os setup or broken mouse/trackpad. Let me try it on other machine.

@xiota
Copy link
Contributor Author

xiota commented Jun 8, 2023

I'm using Textual v0.27.0. Looks like baca reqs specify Textual v0.16.0. Glitchy scroll behavior seems to result from some change in Textual v0.17.0.

@wustho
Copy link
Owner

wustho commented Jun 8, 2023

@xiota maybe we should raise this glitchy issue to textual?

@xiota
Copy link
Contributor Author

xiota commented Jun 8, 2023

maybe we should raise this glitchy issue to textual?

I agree. I'll check to make sure it isn't already reported. If it isn't, I'll open a new issue and @ you so you can add info about the 2-line scrolling.

@wustho
Copy link
Owner

wustho commented Jun 8, 2023

@xiota Thanks, mate. No worries about 2 line scroll tho, I think it has to do with signal being passed to parent widget, so the app and screen get scrolled then produces 2 line scroll. Might be also textual issue, but let me look at it for a while.

@xiota xiota force-pushed the pr_scroll branch 2 times, most recently from a0f7f33 to cb944e9 Compare November 11, 2023 20:14
@xiota
Copy link
Contributor Author

xiota commented Nov 11, 2023

Did not get around to opening an issue upstream, but this seems to be a definite API change in 0.17.0 (2023-03-29) because the upstream examples were modified. Force pushed to sync with main. Changed textual requirement to >=0.17.0 <1.0.0. Manually edited pyproject.toml. Is that the correct way?

Note: I'm adding the changes for contents.py to aur/baca-ereader-git because Arch Linux is definitely affected by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glitchy scrolling with (touchpad emulated) mouse wheel
2 participants