Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epy crashed when changing the size of the terminal #61

Closed
rekinyz opened this issue Aug 3, 2022 · 8 comments
Closed

epy crashed when changing the size of the terminal #61

rekinyz opened this issue Aug 3, 2022 · 8 comments
Labels
bug Something isn't working

Comments

@rekinyz
Copy link

rekinyz commented Aug 3, 2022

got following error msg:

_curses.error: addwstr() returned ERR

@wustho
Copy link
Owner

wustho commented Aug 4, 2022

That's pretty strange... Somehow I cannot recreate the issue when resizing.

Can you elaborate step by step to reproduce the error?

@rekinyz
Copy link
Author

rekinyz commented Aug 6, 2022

  1. installed python 3.9.13 with asdf-vm
  2. tested on two different laptops with pure ubuntu and wsl2 respectively.
  3. created a clean python 3.9.13 .venv
  4. installed epy-reader latest version which is (2022.4.18) with poetry
  5. opened up randomly an .epub
  6. tried to resize terminal window
  7. epy crashed
Traceback (most recent call last):
  File "/home/user/.venv/bin/epy", line 8, in <module>
    sys.exit(main())
  File "/home/user/.venv/lib/python3.9/site-packages/epy.py", line 3988, in main
    filepath = curses.wrapper(preread, filepath)
  File "/home/user/.asdf/installs/python/3.9.13/lib/python3.9/curses/__init__.py", line 94, in wrapper
    return func(stdscr, *args, **kwds)
  File "/home/user/.venv/lib/python3.9/site-packages/epy.py", line 3887, in preread
    reading_state_or_ebook = reader.read(reading_state)
  File "/home/user/.venv/lib/python3.9/site-packages/epy.py", line 3156, in read
    board.write(reading_state.row)
  File "/home/user/.venv/lib/python3.9/site-packages/epy.py", line 1715, in write
    self.screen.addstr(n_row, self.x, text_line)
_curses.error: addwstr() returned ERR

@wustho
Copy link
Owner

wustho commented Aug 6, 2022

Thanks for complete traceback! Will look into that.

Another question, does it work for other epub file?

@rekinyz
Copy link
Author

rekinyz commented Aug 6, 2022

nope, tested on diverse epub files and even with different languages

@3N4N
Copy link
Contributor

3N4N commented Sep 18, 2022

I also cannot reproduce. In Ubuntu 20.04 with python 3, epy handles resizing terminal beautifully.

Although, in Windows, resizing the terminal garbles the screen and remains garbled when resized back to original size. But I suspect that's a Windows-specific (win-curses) issue.

@indam
Copy link

indam commented Feb 1, 2023

Having the same issue here, crashes with this book when I turn to content pages, manjaro linux.
https://drive.google.com/file/d/1thTzyoGivHRBOa-yr1mys7-3W15PGHVe/view?usp=sharing

@wustho wustho added the bug Something isn't working label Feb 8, 2023
wustho added a commit that referenced this issue Feb 8, 2023
* Initial fix

* Removed older codes

* Bump version

* Update funding
@wustho
Copy link
Owner

wustho commented Feb 8, 2023

This seems to be a bug with python's curses itself: https://bugs.python.org/issue8243

Kinda fixed it for epy version v2023.2.8, so if you guys want to try upgrading it via pip and let me know if the issue still persist.

@indam
Copy link

indam commented Feb 9, 2023

This seems to be a bug with python's curses itself: https://bugs.python.org/issue8243

Kinda fixed it for epy version v2023.2.8, so if you guys want to try upgrading it via pip and let me know if the issue still persist.

Thank you for your great work, this issue was fixed.

@wustho wustho closed this as completed Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants