New data set dat.barone2019, added data tests, added concepts to documentation, fixed typos #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to current wviechtb version
Added dat.barone2019 and fixed a typo in dat.ho2012
Checks to see if an rma.uni object can be made then checks the results to make sure it was done correctly
added tests for dat.bangertdrowns2004 and dat.begg1989
kylehamilton
changed the title
|
To address one of the tasks on the todo list (#1) I've added a couple of tests for dat.bangertdrowns2004, dat.barone2019, and dat.begg1989 to make sure the data in metadat produces the right results in metafor. If you like this @wviechtb I'll do the rest of them over the coming month or so, if you don't like it then just remove the tests in the pull request. I have no idea what I'm doing so I just guessed at what I thought was a good set of tests. I just copied the analysis provided in the documentation but I did not cross-reference it with what was published in the articles if we need to do that I can add it to my list. |
adding feild of study for each data file
kylehamilton
changed the title
Finished adding the base level of academic fields to all of the documentation
Concept added to documentation
For data that was in metafor I moved the tests over to metadat and changed the tests I wrote for the other datasets to match the correct format
For data that was in metafor I moved the tests over to metadat and changed the tests I wrote for the other datasets to match the correct format
Data testing now checks md5 hash, data dimensions, and data types.
Updated data testing. Data testing now checks md5 hash, data dimensions, and data types.
forgot to do this
Added data label check
dat.barone2019.Rd and dat.lim2014.Rd had example over 100 chr long. Also dat.pritz1997.Rd throws erros so it is set to \dontrun
Added Tests Fixed Travis and Codecov
|
I have made way too many changes for one pull request. In the future I will not do this, I got a little carried away. |
We need to discuss the testing issue, so removing tests for now.
We need to discuss the testing issue, so removing tests for now.
We need to discuss the testing issue, so removing tests for now.
We need to discuss the testing issue, so removing tests for now.
We need to discuss the testing issue, so removing tests for now.
We need to discuss the testing issue, so removing tests for now.
We need to discuss the testing issue, so removing tests for now.
We need to discuss the testing issue, so removing tests for now.
We need to discuss the testing issue, so removing tests for now.
We need to discuss the testing issue, so removing tests for now.
We need to discuss the testing issue, so removing tests for now.
|
Thanks! I threw out all the tests (for now). We need to discuss first whether we want to go that direction. |
Closed
wviechtb
pushed a commit
that referenced
this pull request
Oct 19, 2019
Merge pull request #5 from kylehamilton/master
kylehamilton
added a commit
that referenced
this pull request
Aug 14, 2021
…date Kylehamilton documentation update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new data set #3
Citation
Barone, P., Corradi, G., & Gomila, A. (2019). Infants’ performance in spontaneous-response false belief tasks: A review and meta-analysis. Infant Behavior and Development, 57, 101350. https://doi.org/10.1016/j.infbeh.2019.101350
OSF
https://osf.io/re8uj/?view_only=d2605771dd664831a104318db9ff7aa9
Fixes minor typo that threw a warning during package build #4
Changed three cases of \italic into \emph