airframe-http: Retry on Finagle's ChannelClosedException (#1089)

Author: xerial

airframe-http/src/main/scala/wvlet/airframe/http/HttpClientException.scala

@@ -15,13 +15,15 @@ package wvlet.airframe.http
 import java.io.{EOFException, IOException}
 import java.lang.reflect.InvocationTargetException
 import java.net._
+import java.nio.channels.ClosedChannelException
 import java.util.concurrent.{ExecutionException, TimeoutException}
 
 import javax.net.ssl.{SSLException, SSLHandshakeException, SSLKeyException, SSLPeerUnverifiedException}
 import wvlet.airframe.control.ResultClass
 import wvlet.airframe.control.ResultClass.{Failed, Succeeded, nonRetryableFailure, retryableFailure}
 import wvlet.airframe.control.Retry.RetryContext
 import wvlet.log.LogSupport
+
 import scala.language.existentials
 
 /**
@@ -120,7 +122,9 @@ object HttpClientException extends LogSupport {
       "Idle connections will be closed".r
     )
 
-    retriable400ErrorMessage.find { pattern => pattern.findFirstIn(m).isDefined }.isDefined
+    retriable400ErrorMessage.find { pattern =>
+      pattern.findFirstIn(m).isDefined
+    }.isDefined
   }
 
   /**
@@ -164,10 +168,11 @@ object HttpClientException extends LogSupport {
     case e: java.lang.InterruptedException =>
       // Retryable when the http client thread execution is interrupted.
       retryableFailure(e)
-    case e: ProtocolException => retryableFailure(e)
-    case e: ConnectException  => retryableFailure(e)
-    case e: EOFException      => retryableFailure(e)
-    case e: TimeoutException  => retryableFailure(e)
+    case e: ProtocolException      => retryableFailure(e)
+    case e: ConnectException       => retryableFailure(e)
+    case e: EOFException           => retryableFailure(e)
+    case e: TimeoutException       => retryableFailure(e)
+    case e: ClosedChannelException => retryableFailure(e)
     case e: SocketException =>
       e match {
         case se: BindException            => retryableFailure(e)
@@ -177,8 +182,17 @@ object HttpClientException extends LogSupport {
         case other =>
           nonRetryableFailure(e)
       }
+    // Exceptions from Finagle. Using the string class names so as not to include Finagle dependencies.
+    case e: Throwable if finagleRetryableExceptionClasses.contains(e.getClass().getName) =>
+      retryableFailure(e)
   }
 
+  private[http] val finagleRetryableExceptionClasses = Set(
+    "com.twitter.finagle.ChannelClosedException",
+    "com.twitter.finagle.ReadTimedOutException",
+    "com.twitter.finagle.WriteTimedOutException"
+  )
+
   def sslExceptionClassifier: PartialFunction[Throwable, Failed] = {
     case e: SSLException =>
       e match {