-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] airframe-msgpack: Pure-Scala MessagePack SPI + Implementation #127
Conversation
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
=========================================
- Coverage 83.54% 0% -83.55%
=========================================
Files 98 93 -5
Lines 3445 3903 +458
Branches 321 272 -49
=========================================
- Hits 2878 0 -2878
- Misses 567 3903 +3336
Continue to review full report at Codecov.
|
* Message Packer interface | ||
*/ | ||
trait Packer { | ||
def packNil: Packer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def packNil: this.type
is better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. I'll use this.type
391c93c
to
f76bec3
Compare
f092c12
to
e2fdafd
Compare
dc9097a
to
011f2ee
Compare
011f2ee
to
e606731
Compare
e606731
to
3a64360
Compare
5a14e58
to
e66cf40
Compare
Design considerations: