Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] airframe-msgpack: Pure-Scala MessagePack SPI + Implementation #127

Merged
merged 36 commits into from
May 24, 2018

Conversation

xerial
Copy link
Member

@xerial xerial commented Dec 3, 2017

Design considerations:

  • pure-scala implementation for the use in Scala (JVM), Scala.js, and Scala.native
  • Support offset based packer/unpacker (for better error handling without moving buffer internal cursors)
  • Support marking on memory buffers (for holding memory region that contains a value)

@codecov
Copy link

codecov bot commented Dec 3, 2017

Codecov Report

Merging #127 into master will decrease coverage by 83.54%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #127       +/-   ##
=========================================
- Coverage   83.54%     0%   -83.55%     
=========================================
  Files          98     93        -5     
  Lines        3445   3903      +458     
  Branches      321    272       -49     
=========================================
- Hits         2878      0     -2878     
- Misses        567   3903     +3336
Impacted Files Coverage Δ
...main/scala/wvlet/airframe/codec/MessageCodec.scala 0% <ø> (-66.67%) ⬇️
.../scala/wvlet/airframe/msgpack/io/ArrayBuffer.scala 0% <0%> (ø)
...ala/wvlet/airframe/msgpack/spi/MessageFormat.scala 0% <0%> (ø)
...main/scala/wvlet/airframe/msgpack/spi/Buffer.scala 0% <0%> (ø)
...cala/wvlet/airframe/msgpack/spi/OffsetPacker.scala 0% <0%> (ø)
...ala/wvlet/airframe/msgpack/io/StreamUnpacker.scala 0% <0%> (ø)
...la/wvlet/airframe/msgpack/spi/OffsetUnpacker.scala 0% <0%> (ø)
...in/scala/wvlet/airframe/codec/PrimitiveCodec.scala 0% <0%> (-85.28%) ⬇️
...ain/scala/wvlet/airframe/codec/StandardCodec.scala 0% <0%> (-97.3%) ⬇️
...scala/wvlet/airframe/msgpack/io/StreamPacker.scala 0% <0%> (ø)
... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91cc9b...c7d23da. Read the comment docs.

* Message Packer interface
*/
trait Packer {
def packNil: Packer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def packNil: this.type is better?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. I'll use this.type

@xerial xerial merged commit c7d23da into master May 24, 2018
@xerial xerial deleted the msgpack-interface branch June 4, 2018 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants