-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Metadata describer #155
Conversation
…riber and default implementation for FlowRepresentable - RAG
…ing SwiftCurrent but it does not behave as one would expect with classes - RAG
Tests/SwiftCurrentTests/FlowRepresentableMetadataDescriberConsumerTests.swift
Outdated
Show resolved
Hide resolved
…s showcase scenarios that we're supporting - RAG
Codecov Report
@@ Coverage Diff @@
## data-driven #155 +/- ##
==============================================
Coverage ? 89.70%
==============================================
Files ? 96
Lines ? 2506
Branches ? 0
==============================================
Hits ? 2248
Misses ? 258
Partials ? 0 Continue to review full report at Codecov.
|
Sources/SwiftCurrent/Protocols/FlowRepresentableMetadataDescriber.swift
Outdated
Show resolved
Hide resolved
…scriber Co-authored-by: Tyler Thompson <33705774+Tyler-Keith-Thompson@users.noreply.github.com>
… that I added in - RAG
…ry when Self is a View and FlowRepresentable - RAG
…xtendedFlowRepresentableMetadata - RAG
I think this is probably good enough to start updating this to Ready for Review. I'm out for most if not all of next week (and tomorrow) so if we want to make more progress on this, feel free to take it and keep working on it without me. |
Looks like the linter is only failing due to two TODOs that I feel are appropriate to stay until |
Checklist: