Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Metadata describer #155

Merged
merged 12 commits into from
Jan 14, 2022
Merged

Adds Metadata describer #155

merged 12 commits into from
Jan 14, 2022

Conversation

Richard-Gist
Copy link
Collaborator

@Richard-Gist Richard-Gist commented Dec 7, 2021

Checklist:

  • Did you sign the Contributor License Agreement?
  • Is the linter reporting 0 errors? 0 Errors for the code in this PR
  • Did you comply with our styleguide?
  • Is there adequate test coverage for your new code?
  • Does the CI pipeline pass? For what this PR touches
  • Did you update the documentation?
  • Have you done everything you can to make sure that errors that can occur are compile-time errors, and if they have to be runtime do you have adequate tests and documentation around those runtime errors? For more details.

…riber and default implementation for FlowRepresentable - RAG
…ing SwiftCurrent but it does not behave as one would expect with classes - RAG
@Richard-Gist Richard-Gist added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 7, 2021
@Richard-Gist Richard-Gist added this to the Data Driven Workflows milestone Dec 7, 2021
@Richard-Gist Richard-Gist changed the base branch from main to data-driven December 7, 2021 19:44
…s showcase scenarios that we're supporting - RAG
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2021

Codecov Report

❗ No coverage uploaded for pull request base (data-driven@1d430cb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             data-driven     #155   +/-   ##
==============================================
  Coverage               ?   89.70%           
==============================================
  Files                  ?       96           
  Lines                  ?     2506           
  Branches               ?        0           
==============================================
  Hits                   ?     2248           
  Misses                 ?      258           
  Partials               ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d430cb...1749114. Read the comment docs.

@Richard-Gist
Copy link
Collaborator Author

I think this is probably good enough to start updating this to Ready for Review. I'm out for most if not all of next week (and tomorrow) so if we want to make more progress on this, feel free to take it and keep working on it without me.

@Richard-Gist Richard-Gist marked this pull request as ready for review January 7, 2022 22:44
@morganzellers
Copy link
Contributor

Looks like the linter is only failing due to two TODOs that I feel are appropriate to stay until data-driven merges into main, so I'm approving & merging.

@morganzellers morganzellers merged commit cca34ea into data-driven Jan 14, 2022
@morganzellers morganzellers deleted the metadata-describer branch January 14, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants