Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling the ability to handle default arguments in the json spec #170

Merged
merged 19 commits into from
Feb 4, 2022
Merged

Enabling the ability to handle default arguments in the json spec #170

merged 19 commits into from
Feb 4, 2022

Conversation

nickkaczmarek
Copy link
Contributor

@nickkaczmarek nickkaczmarek commented Feb 3, 2022 •
edited
Loading

Checklist:

@Tyler-Keith-Thompson
[data-driven-extendable-json] - Starting the process of decoding more…
c4e54b0 
… complex json specs. - tt nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
@nickkaczmarek nickkaczmarek self-assigned this Feb 3, 2022
@nickkaczmarek nickkaczmarek added the enhancement New feature or request label Feb 3, 2022
@nickkaczmarek nickkaczmarek added this to the Data Driven Workflows milestone Feb 3, 2022
Nick Kaczmarek and others added 17 commits February 3, 2022 12:00
@Tyler-Keith-Thompson
[data-driven-extendable-json] - Testing that code should throw if flo…
683d313 
…wRepresentableName does not match platform - tt nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
@Tyler-Keith-Thompson @morganzellers
[data-driven-extendable-json] - Tested that decoder throws when Launc…
60a7d50 
…hStyle or FlowPersistence do not match the platform. Updated error messages. - tt mz nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Morgan Zellers <Morgan.Zellers@gmail.com>
@Tyler-Keith-Thompson @morganzellers
[data-driven-extendable-json] - Reducing decoder duplication with Pla…
c37811a 
…tformDecodable type. - tt mz nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Morgan Zellers <Morgan.Zellers@gmail.com>
@Tyler-Keith-Thompson @morganzellers
[data-driven-extendable-json] - Remove whitespace to fix linting erro…
ccc12d1 
…rs. - tt mz nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
Co-authored-by: Morgan Zellers <Morgan.Zellers@gmail.com>
@Tyler-Keith-Thompson
[data-driven-extendable-json] - Adds multiplatform tests for data dri…
6b150e5 
…ven json specs. - tt nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
@Tyler-Keith-Thompson
[data-driven-extendable-json] - Working on adding Fastlane for platfo…
1bf9018 
…rm tests. - tt nk

Co-authored-by: Tyler Thompson <Tyler.Thompson@wwt.com>
@Tyler-Keith-Thompson
[data-driven-extendable-json] - Updated PR_CI to try and run the plat…
748ccd4 
…form tests, they were having problems locally so it is dubious they will work now - TT NK

Co-authored-by: Nick Kaczmarek <Nick.Kaczmarek@wwt.com>
@Tyler-Keith-Thompson
[data-driven-extendable-json] - Just comment out tests for now and ru…
67c5bd0 
…n the multiplatform thing...WORK DAMN YOU - TT
@Tyler-Keith-Thompson
[data-driven-extendable-json] - Added the scheme to the workspace - TT
8e81cfc
@Tyler-Keith-Thompson
[data-driven-extendable-json] - Added back all the schemes that someh…
796e17b 
…ow got deleted - TT
@Tyler-Keith-Thompson
[data-driven-extendable-json] - Ahha, it was a copy pasta error. When…
3cc805d 
… we took from build for SPM we kept the line that deleted the workspace, however for this that is not necessary or desired - TT
@Tyler-Keith-Thompson
[data-driven-extendable-json] - Whoops, workspace was in a different …
d8e255b 
…directory - TT
@Tyler-Keith-Thompson
[data-driven-extendable-json] - Execute multiplatform tests in parall…
162e9ee 
…el - TT
@Tyler-Keith-Thompson
[data-driven-extendable-json] - Added multiplatform tests to the Swif…
bb5d59a 
…tCurrent scheme, because it does not cost any extra to run them along with everything else, also refactored to use available check instead of compilation conditions - TT
@Tyler-Keith-Thompson
[data-driven-extendable-json] - Minor refactor to make PlatformDecoda…
32b7151 
…ble even more friendly - TT
@Tyler-Keith-Thompson
[data-driven-extendable-json] - VERY necessary whitespace fix - TT
1ea7d4b
@Tyler-Keith-Thompson
[data-driven-extendable-json] - The availability check lied to me loc…
4e8f628 
…ally...good thing the pipeline works - TT
@nickkaczmarek nickkaczmarek marked this pull request as ready for review February 4, 2022 16:14
@nickkaczmarek nickkaczmarek requested a review from a team as a code owner February 4, 2022 16:14
@nickkaczmarek nickkaczmarek mentioned this pull request Feb 4, 2022
Closed
morganzellers
morganzellers approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@morganzellers morganzellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super exciting and looks awesome.

@morganzellers morganzellers merged commit f0566d8 into data-driven Feb 4, 2022
@morganzellers morganzellers deleted the data-driven-extendable-json branch February 4, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morganzellers morganzellers morganzellers approved these changes

@Tyler-Keith-Thompson Tyler-Keith-Thompson Awaiting requested review from Tyler-Keith-Thompson

Assignees

@nickkaczmarek nickkaczmarek

Labels
enhancement New feature or request
Projects
None yet
Milestone
Data Driven Workflows
Development

Successfully merging this pull request may close these issues.
3 participants
@nickkaczmarek @morganzellers @Tyler-Keith-Thompson