Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance discovery options for service health and versioning strategy #2

Closed
wwwlicious opened this issue Apr 10, 2016 · 2 comments
Closed

Enhance discovery options for service health and versioning strategy #2

wwwlicious opened this issue Apr 10, 2016 · 2 comments
Labels
Feature

Comments

@wwwlicious
Copy link
Owner

When resolving the endpoint for a requestDTO, add a default option to prefer healthy services over services at 'warning' level. Critical health services to be ignored and filtered out.

By default prefer the highest version service available (require that Version be numeric on registration?)

If the requestDTO contains a property named "Version", this should be used if a matching service version is found.

Provide feature properties to:
Ignore Warning services
Favour lowest version
@wwwlicious
Copy link
Owner Author

latest PR returns only healthy services.

wwwlicious added a commit that referenced this issue Apr 18, 2016
@wwwlicious
Refining service lookups for health checks (#6)
61be01b 
* Updating ss versions to .55
Adding default 'ServiceStack' tag to service registrations

* Updating to use the IServiceGateway and adding ConsulServiceGatewayFactory and
tests.
Registering factory in plugin with IoC and removing IServiceClient registration
Adding consul web ui plugin link on metadata page
Changing plugin constructor to take a IServiceGateway delegate to allow consumers to customise client/config for external service calls.
Updating demo's and readme to reflect changes.

* removing dotsettings file

* Fixing package refs

* few readme corrections

* Hiding health services from metadata page (#1)

Moving service location logic from DefaultDiscoveryRequestTypeResolver to the ConsulClient
Adding GatewayServiceDiscoveryException for all consul lookup exceptions
Adding prefix to service and tag and healthcheck registration
Adding service lookups by tag
Adding service sorting by round trip times
Adding service filtering by passing health
Adding public member docs
Adding tests
Few readme updates

* Fixing tests (#2)

* Hiding health services from metadata page
Moving service location logic from DefaultDiscoveryRequestTypeResolver to the ConsulClient
Adding GatewayServiceDiscoveryException for all consul lookup exceptions
Adding prefix to service and tag and healthcheck registration
Adding service lookups by tag
Adding service sorting by round trip times
Adding service filtering by passing health
Adding public member docs
Adding tests
Few readme updates

* Fixing tests

* Skipping test

 test works locally but fails on appveyor, getting expected message of test below suggesting state is being shared somewhere
wwwlicious added a commit that referenced this issue Apr 18, 2016
@wwwlicious
Fixing tests (#2)
2d090f3 
* Hiding health services from metadata page
Moving service location logic from DefaultDiscoveryRequestTypeResolver to the ConsulClient
Adding GatewayServiceDiscoveryException for all consul lookup exceptions
Adding prefix to service and tag and healthcheck registration
Adding service lookups by tag
Adding service sorting by round trip times
Adding service filtering by passing health
Adding public member docs
Adding tests
Few readme updates

* Fixing tests
@wwwlicious
Copy link
Owner Author

Closing for speciific issues

#9 - Versioning
#10 - Returning services with 'warning' health

wwwlicious pushed a commit that referenced this issue May 27, 2016
Merge pull request #1 in SS/servicestack.discovery.consul from bitbuc…
f32f5df 
…ket-master to master

* commit '722edf09f89fc059ea8ea1f2eda6d799c10d13a5':
  Pr 12 (#13)
  Adding http caching to gatewayfactory (#11)
  Cleaned up and extended type selection to include RestrictAttribute Updated readme with type exclusion examples
  Refining service lookups for health checks (#6)
  Skipping test
  Fixing tests (#2)
  Fixing tests
  Hiding health services from metadata page (#1)
  Hiding health services from metadata page Moving service location logic from DefaultDiscoveryRequestTypeResolver to the ConsulClient Adding GatewayServiceDiscoveryException for all consul lookup exceptions Adding prefix to service and tag and healthcheck registration Adding service lookups by tag Adding service sorting by round trip times Adding service filtering by passing health Adding public member docs Adding tests Few readme updates
  Update HealthCheckServiceTests.cs
  Adding custom health checks (#5)
  few readme corrections
  Implement IServiceGateway changes (#4)
  Fixing package refs
  removing dotsettings file
  Updating to use the IServiceGateway and adding ConsulServiceGatewayFactory and tests. Registering factory in plugin with IoC and removing IServiceClient registration Adding consul web ui plugin link on metadata page Changing plugin constructor to take a IServiceGateway delegate to allow consumers to customise client/config for external service calls. Updating demo's and readme to reflect changes.
  Updating ss versions to .55 Adding default 'ServiceStack' tag to service registrations
  Update README.md
  Update README.md
  Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wwwlicious