Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initials on testimonials page #81

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Sep 15, 2023

Description

This PR fixes the issue with the initials displayed on the testimonials page. Previously, all testimonials displayed the initials "JE" regardless of the actual user initials. This PR introduces dynamic initials based on the user's name.

Summary of Changes

  • Modified the Testimonials component to derive the initials from the user's name.
  • Replaced the hardcoded initials in the User component with the derived initials.
  • Passed the derived initials as a prop to the User component.

Please review and merge this PR. Thank you!

Fixes #77.


To checkout this PR branch, run the following command in your terminal:

git checkout sweep/fix-testimonials-initials_12

🎉 Latest improvements to Sweep:


💡 To get Sweep to edit this pull request, you can:

  • Leave a comment below to get Sweep to edit the entire PR
  • Leave a comment in the code will only modify the file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-ai sweep-ai bot added the sweep Assigns Sweep to an issue or pull request. label Sep 15, 2023
@netlify
Copy link

netlify bot commented Sep 15, 2023

Deploy Preview for gleaming-biscotti-07856b ready!

Name Link
🔨 Latest commit a9bdffc
🔍 Latest deploy log https://app.netlify.com/sites/gleaming-biscotti-07856b/deploys/6516361b2dc60a000874045c
😎 Deploy Preview https://deploy-preview-81--gleaming-biscotti-07856b.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kevinlu1248
Copy link
Collaborator

The files don't parse.

@sweep-ai
Copy link
Contributor Author

sweep-ai bot commented Sep 15, 2023

🚀 Wrote Changes

The files don't parse.

Hi @kevinlu1248,

I decided to make the following changes:

File Path Proposed Changes
src/components/Testimonials.tsx Modify src/components/Testimonials.tsx with contents:
• Move the calculation of initials inside the return statement of the Testimonial component function. Wrap the calculation in curly braces to indicate it's a JavaScript expression.
• Pass the calculated initials to the User component as a prop.

@ergomake
Copy link

ergomake bot commented Sep 26, 2023

The Ergomake platform will be discontinued on the 15th of October 2023.

Hi there 👋

You’ve just reached your simultaneous environments limit.

Please talk to us at contact@ergomake.dev to bump your limits.

Alternatively, you can close a PR with an existing environment, and reopen this one to get a preview.

Thanks for using Ergomake!

Click here to disable Ergomake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: Fix the initials on the testimonials page, they all say JE
1 participant