Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edge case in decoder when very first OP is QOI_OP_RUN / Add CI with official test suite #23

Merged
merged 3 commits into from
Feb 24, 2024
Merged

Fix edge case in decoder when very first OP is QOI_OP_RUN / Add CI with official test suite #23

merged 3 commits into from
Feb 24, 2024

Conversation

wx257osn2
Copy link
Owner

No description provided.

@wx257osn2
Copy link
Owner Author

wx257osn2 commented Feb 21, 2024 •
edited
Loading

According to phoboslab/qoi#258, QOI accepts QOI_OP_RUN at first op. Current qoixx implementation doesn't consider about that situation, thus CI has been failed. Fixing...

@wx257osn2 wx257osn2 changed the title Add CI with official test suite Fix edge case in decoder when very first OP is QOI_OP_RUN / Add CI with official test suite Feb 21, 2024
@wx257osn2 wx257osn2 force-pushed the add-test-with-suite branch 2 times, most recently from 0003300 to 6d50faa Compare February 24, 2024 00:45
@wx257osn2
Copy link
Owner Author

Note: qoi_test_images.zip/edgecase.png is 3-channel png, but qoi_test_images.zip/edgecase.qoi has 4-channel, so png' and png'' where png->qoi->png' and qoi->png'' have never been matched

@wx257osn2 wx257osn2 merged commit 395017e into master Feb 24, 2024
2 of 3 checks passed
@wx257osn2 wx257osn2 deleted the add-test-with-suite branch February 25, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wx257osn2