-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example files on website missing #192
Comments
You can found examples with build files in samples folder - https://github.com/wxIshiko/wxCharts/tree/main/samples |
Just started looking at this the first time today. Would be nice to have the samples included in CMake as well. Managed to build them of master, but they don't actually seems to display anything so far. Will keep experimenting. Seems to be various warnings about the header #defines not being the same: /wx/wxCharts//include/wx/charts/wxareachartctrl.h:37:9: note: '_WX_CHARTS_WXAREACHARTCTRL_H' is defined here; did you mean 'WX_CHARTS_WXAREACHARTCTRL_H'? The ifdef and defs don't match up. |
You are correct, This seems to be an isolated occurrence in wxareachartctrl.h. The others seem fine. I'm doing a quick commit for this now. |
Header guard fixed in 632f277 |
Thanks for responding so quickly. I noticed this while compiling on MacOS trying out for the first time. I can build all the samples, but out of all the samples only the following actually display something:
But they look good, so I assume there is some small difference in the start up code that misbehaving on OSX. The others all run and show a menu, but don’t seem to open the window. I will have a compare to see what’s different. For the warnings: wxmath2dplotctrl.h:36:9: warning: 'WX_CHARTS_WXMATH2DPLOTCTRL_H' There are a few warnings about not using override from Clang: wxpiechartctrl.h:73:25: warning: 'GetChart' overrides a member function but is not marked ‘override' |
Ah unfortunately I don't have an OSX machine on which I can test so errors are more likely there. But I'll fix the warnings mentioned here. |
Got all the samples compiling and running on MacOS on ARM built against wxWidgets-3.1.6. At the end of each frame constructor just had to add: Centre(); The main window was opening, but the sizers for some reason where making the window width/height to 0. I noticed the PolarArea axes labels do not scale with rest of the chart when resized. Also am I right in thinking the time series sample does not do anything as yet? |
Thanks for responding so quickly. I noticed this while compiling on MacOS trying out for the first time.
I can build all the samples, but out of all the samples only the following actually display something:
pie chart
column chart
shared charts categorical data
But they look good, so I assume there is some small difference in the start up code that misbehaving on OSX. The others all run and show a menu, but don’t seem to open the window. I will have a compare to see what’s different.
For the warnings:
wxmath2dplotctrl.h:36:9: warning: '_WX_CHARTS_WXMATH2DPLOTCTRL_H_'
wxareachartctrl.h:36:9: warning: '_WX_CHARTS_WXAREACHARTCTRL_H_'
There are a few warnings about not using override from Clang:
wxpiechartctrl.h:73:25: warning: 'GetChart' overrides a member function but is not marked ‘override'
wxpiechart.h:41:41: warning: 'GetCommonOptions' overrides a member function but is not marked 'override'
wxdoughnutchartctrl.h:47:30: warning: 'GetChart' overrides a member function but is not marked ‘override'
wxdoughnutchart.h:43:41: warning: 'GetCommonOptions' overrides a member function but is not marked ‘override'
Thanks,
Giles
On 4 Jun 2022, at 13:14, Xavier Leclercq ***@***.***> wrote:
Header guard fixed in 632f277 <632f277>
—
Reply to this email directly, view it on GitHub <#192 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEDCHCPFKRGXLN7MZFVPNALVNNCDLANCNFSM5BWFCFTA>.
You are receiving this because you commented.
|
linking to the example files in github, and going to your website leads to an empty html page. Id love to see some exsmples on how to use these charts
The text was updated successfully, but these errors were encountered: