Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module build failed after update to 2.0.1 #348

Closed
nejc-susin opened this issue Jan 5, 2022 · 3 comments
Closed

Module build failed after update to 2.0.1 #348

nejc-susin opened this issue Jan 5, 2022 · 3 comments

Comments

@nejc-susin
Copy link

Hi,
I am getting the below error on 2.0.1, but not on 2.0.0.

Error: Module build failed (from ./node_modules/vue-md-loader/index.js):
TypeError: this.getOptions is not a function
    at Object.module.exports (E:\git\project\node_modules\vue-md-loader\index.js:7:24)
    at eval (webpack-internal:///./src/assets/markdown.md:1:7)
    at Object../src/assets/markdown.md (https://localhost/js/app.js:5881:1)
    at __webpack_require__ (https://localhost/js/app.js:854:30)
    at fn (https://localhost/js/app.js:151:20)
    at VueComponent.created 
    ...

I could be totally wrong, but looking at the source and what changed, I would guess that loader-utils should not have been removed like they were in 59ae702. The v3 way of calling getOptions() makes it seem like we don't need the dependency but I guess we do.

Downgrading fixes it for me, but I thought it was worth pointing out anyway.

@nejc-susin nejc-susin changed the title Not working after update to 2.0.1 Module build failed after update to 2.0.1 Jan 5, 2022
wxsms added a commit that referenced this issue Jan 6, 2022
wxsms added a commit that referenced this issue Jan 6, 2022
@wxsms
Copy link
Owner

wxsms commented Jan 6, 2022

Hello. Thanks for report. I guess this is a mistake, if you're using webpack v5, this should not happen. I just updated the release note to point this out. If you still need webpack v4 or lower, pls use 1.x of this plugin. Thanks.

If you are using webpack v5 and this issue happens, pls let me know. We can continue on this topic.

@nejc-susin
Copy link
Author

That makes sense. I cannot go into webpack upgrade at the moment, so I'll stay on the old version. Thanks for clearing it up!

@wxsms
Copy link
Owner

wxsms commented Jan 6, 2022

Welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants