Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Replace execa with nano-spawn for smaller package size #1042

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

Timeraa
Copy link
Contributor

@Timeraa Timeraa commented Oct 4, 2024

Closes #1037

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 821ca74
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/67004001c807a5000874c132
😎 Deploy Preview https://deploy-preview-1042--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for hopping on this so fast lol. If you wanna look into any other package size optimizations like this, that'd be great! I know you also mentioned locking down the esbuild versions?

packages/wxt/src/core/package-managers/bun.ts Outdated Show resolved Hide resolved
packages/wxt/e2e/tests/init.test.ts Outdated Show resolved Hide resolved
Copy link

pkg-pr-new bot commented Oct 4, 2024

Open in Stackblitz

@wxt-dev/auto-icons

pnpm add https://pkg.pr.new/@wxt-dev/auto-icons@1042

@wxt-dev/module-react

pnpm add https://pkg.pr.new/@wxt-dev/module-react@1042

@wxt-dev/i18n

pnpm add https://pkg.pr.new/@wxt-dev/i18n@1042

@wxt-dev/module-solid

pnpm add https://pkg.pr.new/@wxt-dev/module-solid@1042

@wxt-dev/module-svelte

pnpm add https://pkg.pr.new/@wxt-dev/module-svelte@1042

@wxt-dev/module-vue

pnpm add https://pkg.pr.new/@wxt-dev/module-vue@1042

wxt

pnpm add https://pkg.pr.new/wxt@1042

commit: 821ca74

@Timeraa
Copy link
Contributor Author

Timeraa commented Oct 4, 2024

Dang it check failed, worked locally a second ago

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.92%. Comparing base (faa4fcb) to head (821ca74).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/wxt/src/cli/cli-utils.ts 50.00% 1 Missing ⚠️
packages/wxt/src/core/package-managers/bun.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1042      +/-   ##
==========================================
+ Coverage   81.79%   81.92%   +0.13%     
==========================================
  Files         127      127              
  Lines        6635     6634       -1     
  Branches     1102     1101       -1     
==========================================
+ Hits         5427     5435       +8     
+ Misses       1194     1185       -9     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 changed the title chore: replace execa with nano-spawn perf: replace execa with nano-spawn Oct 4, 2024
@aklinker1 aklinker1 changed the title perf: replace execa with nano-spawn perf: Replace execa with nano-spawn for smaller package size Oct 4, 2024
@aklinker1
Copy link
Collaborator

@Timeraa chore: idk why you downgraded rollup™

Haha if this happens again, run pnpm i --fix-lockfile and it should resolve itself.

Copy link
Collaborator

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Timeraa this good to go? Code looks good to me, and windows tests pass, so I think it's ready to go!

@Timeraa
Copy link
Contributor Author

Timeraa commented Oct 4, 2024

@Timeraa this good to go? Code looks good to me, and windows tests pass, so I think it's ready to go!

If you approve then yeah

@aklinker1 aklinker1 merged commit 6020083 into wxt-dev:main Oct 4, 2024
18 checks passed
@Timeraa Timeraa deleted the remove-execa branch October 4, 2024 21:39
Timeraa added a commit to Timeraa/wxt that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace execa with nano-spawn
2 participants