-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Replace execa
with nano-spawn
for smaller package size
#1042
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for hopping on this so fast lol. If you wanna look into any other package size optimizations like this, that'd be great! I know you also mentioned locking down the esbuild versions?
@wxt-dev/auto-icons
@wxt-dev/module-react
@wxt-dev/i18n
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
wxt
commit: |
Dang it check failed, worked locally a second ago |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1042 +/- ##
==========================================
+ Coverage 81.79% 81.92% +0.13%
==========================================
Files 127 127
Lines 6635 6634 -1
Branches 1102 1101 -1
==========================================
+ Hits 5427 5435 +8
+ Misses 1194 1185 -9
Partials 14 14 ☔ View full report in Codecov by Sentry. |
execa
with nano-spawn
for smaller package size
Haha if this happens again, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Timeraa this good to go? Code looks good to me, and windows tests pass, so I think it's ready to go!
If you approve then yeah |
Closes #1037