Revert regressions found in 0.18.0 #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 26, 2013 13:59
Althugh there is an issue in here, the current implementation is very brittle as looking into the stacktrace is not guaranteed to stay the same across different ruby versions and ruby implementations. This reverts commit fb149e3.
This is an expected feature from Thor. When rendering files, Thor behaves like Sinatra. It works as if the file was embedded in the current Thor class. Therefore, restricting the filename to be just public methods is a wrong limitation that does not fit with how Thor is meant to be used.
sferik
added a commit
that referenced
this pull request
Mar 26, 2013
Revert regressions found in 0.18.0
tricknotes
pushed a commit
to tricknotes/rails
that referenced
this pull request
Dec 4, 2013
See rails/thor@08265a3 for the discussion and rails/thor#316 for the fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert regressions found in 0.18.0 as discussed here: 08265a3