Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default title for govuk_tabs #507

Closed
frankieroberto opened this issue Feb 9, 2024 · 0 comments · Fixed by #521
Closed

Default title for govuk_tabs #507

frankieroberto opened this issue Feb 9, 2024 · 0 comments · Fixed by #521
Assignees

Comments

@frankieroberto
Copy link
Collaborator

The govuk_tabs helper throws an exception if the title argument is omitted. The equivalent Nunjucks component govukTabs defaults the title to "Contents" and doesn’t even include it in the examples.

I’m happy for us to require arguments where it makes sense to (Nunjucks doesn't support required arguments at all with the way that arguments are passed in as a object) – but maybe here we could default to "Contents" too? Not sure how often you'd use another title?

See also #506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants