Move visually hidden space inside element #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for govuk-components ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
frankieroberto
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
👍 I think we can merge this straight away, as it’s what the nunjucks component already does?
Do we consider this a breaking change? I guess it might break some downstream tests, depending on how they were written?
The final decision on how to properly handle the space between the visible and hidden text hasn't been made yet but the general consensus upstream is that it's better inside the visually hidden span than before it. This might be revisited again when a decision has been made and the solution presented in #403 can be used instead.
peteryates
force-pushed
the
move-space-before-visually-hidden-text-inside-span
branch
from
1e6ebca
to
c093a87
Compare
|
Yeah it's definitely a breaking change but the next release will be a big one anyway so the timing is good. |
|
I added a note to the release notes issue #390 |
peteryates
deleted the
move-space-before-visually-hidden-text-inside-span
branch
peteryates
added a commit
to DFE-Digital/early-careers-framework
that referenced
this pull request
Aug 16, 2023
peteryates
added a commit
to DFE-Digital/early-careers-framework
that referenced
this pull request
Aug 16, 2023
peteryates
added a commit
to DFE-Digital/early-careers-framework
that referenced
this pull request
Aug 16, 2023
ltello
pushed a commit
to DFE-Digital/early-careers-framework
that referenced
this pull request
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final decision on how to properly handle the space between the visible and hidden text hasn't been made yet but the general consensus upstream is that it's better inside the visually hidden span than before it.
This might be revisited again when a decision has been made and the solution presented in #403 can be used instead.