Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less needless cloning of the time_zone_designation #5

Closed
wants to merge 1 commit into from
Closed

Less needless cloning of the time_zone_designation #5

wants to merge 1 commit into from

Conversation

Kijewski
Copy link
Contributor

There is no need to clone the string when the data can be shared.

@Kijewski
Copy link
Contributor Author

Thank you very much for this crate! This is a very much needed cornerstone of the rust ecosystem.

@Kijewski
Less needless cloning of the time_zone_designation
f253cfd 
There is no need to clone the string when the data can be shared.
x-hgg-x added a commit that referenced this pull request Feb 20, 2022
@x-hgg-x
Avoid cloning of time zone designations (#5)
172f09b
@x-hgg-x
Copy link
Owner

x-hgg-x commented Feb 20, 2022 •
edited
Loading

Fixed in 172f09b, with Option<Arc<str>> instead to avoid allocations for empty strings.

@x-hgg-x x-hgg-x closed this Feb 20, 2022
@Kijewski Kijewski deleted the pr-arc-str branch February 20, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kijewski @x-hgg-x