Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS CodeCommit HTTP (GRC) #321

Merged
merged 1 commit into from
May 22, 2021
Merged

Support AWS CodeCommit HTTP (GRC) #321

merged 1 commit into from
May 22, 2021

Conversation

xeres
Copy link
Contributor

@xeres xeres commented May 22, 2021

Close #320.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 866647644

  • 10 of 70 (14.29%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.8%) to 81.97%

Changes Missing Coverage Covered Lines Changed/Added Lines %
local_repository.go 3 5 60.0%
getter.go 5 8 62.5%
remote_repository.go 1 13 7.69%
url.go 1 44 2.27%
Totals Coverage Status
Change from base Build 605591638: -3.8%
Covered Lines: 1082
Relevant Lines: 1320

💛 - Coveralls

@Songmu
Copy link
Member

Songmu commented May 22, 2021

Excellent!
I found your trial and error below. I appreciate you taking the time to do this.
https://zenn.dev/xeres/scraps/63579067ec163d

@Songmu Songmu merged commit c62fd67 into x-motemen:master May 22, 2021
Songmu added a commit that referenced this pull request May 22, 2021
## [v1.2.0](v1.1.7...v1.2.0) (2021-05-23)

* Support AWS CodeCommit HTTP (GRC) [#321](#321) ([xeres](https://github.com/xeres))
* Smartcasing [#317](#317) ([bmendric](https://github.com/bmendric))
@imawaki
Copy link

imawaki commented Aug 29, 2021

Hello. Thank you for this great improvement. Would you mind helping me find out why am I getting this message?
git: 'remote-codecommit' is not a git command. See 'git --help'.

8月29日_Sunday_17:55_/Users/imawaki/ghq/github.com/motemen/ghq_[master]
🐄🐄🐄 $ ghq --version
ghq version 1.2.1 (rev:dd139fb)

8月29日_Sunday_17:55_/Users/imawaki/ghq/github.com/motemen/ghq_[master]
🐄🐄🐄 $ ghq get --vcs git codecommit://default@MyDemoRepo
     clone codecommit://default@MyDemoRepo -> /Users/imawaki/ghq/ap-northeast-1/MyDemoRepo
       git clone --recursive codecommit://default@MyDemoRepo /Users/imawaki/ghq/ap-northeast-1/MyDemoRepo
Cloning into '/Users/imawaki/ghq/ap-northeast-1/MyDemoRepo'...
git: 'remote-codecommit' is not a git command. See 'git --help'.
     error failed to get "codecommit://default@MyDemoRepo": /opt/homebrew/bin/git: exit status 128

8月29日_Sunday_17:56_/Users/imawaki/ghq/github.com/motemen/ghq_[master]
🐄🐄🐄 $ echo $GHQ_ROOT
/Users/imawaki/ghq

8月29日_Sunday_17:56_/Users/imawaki/ghq/github.com/motemen/ghq_[master]
🐄🐄🐄 $ cat ~/.gitconfig | grep -A 2 -B 2 codecommit
        diffFilter = diff-highlight

[ghq "codecommit://"]
vcs = git


8月29日_Sunday_17:57_/Users/imawaki/ghq/github.com/motemen/ghq_[master]
🐄🐄🐄 $ echo $AWS_PROFILE


8月29日_Sunday_17:58_/Users/imawaki/ghq/github.com/motemen/ghq_[master]
🐄🐄🐄 $ ghq get --vcs git codecommit://MyDemoRepo
     clone codecommit://MyDemoRepo -> /Users/imawaki/ghq/ap-northeast-1/MyDemoRepo
       git clone --recursive codecommit://MyDemoRepo /Users/imawaki/ghq/ap-northeast-1/MyDemoRepo
Cloning into '/Users/imawaki/ghq/ap-northeast-1/MyDemoRepo'...
git: 'remote-codecommit' is not a git command. See 'git --help'.
     error failed to get "codecommit://MyDemoRepo": /opt/homebrew/bin/git: exit status 128

8月29日_Sunday_17:58_/Users/imawaki/ghq/github.com/motemen/ghq_[master]
🐄🐄🐄 $ which git
/opt/homebrew/bin/git

8月29日_Sunday_18:03_/Users/imawaki/ghq/github.com/motemen/ghq_[master]
🐄🐄🐄 $ git --version
git version 2.30.1

Sorry if I missed some configuration. Thanks in advance.

@xeres
Copy link
Contributor Author

xeres commented Aug 29, 2021

@imawaki
Are you already install git-remote-codecommit?
You should set up access using git-remote-codecommit to access with CodeCommit HTTPS (GRC).
https://docs.aws.amazon.com/codecommit/latest/userguide/setting-up-git-remote-codecommit.html

@imawaki
Copy link

imawaki commented Aug 30, 2021

wow, that's it! Now I installed git-remote-codecommit and successfully cloned my repo 🙇🏻‍♂️🙏
Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for AWS CodeCommit HTTP (GRC)
4 participants