fix: [trivial] fix the error message if nothing is passed to ghq create
#334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfx
changed the title
ghq createghq create
gfx
changed the title
ghq createghq create
|
Maybe it's more helpful if it suggests how to see the subcommand help, just like |
|
Sounds a good idea, but it should be a general improvement rather than this particular fix. |
Songmu
added a commit
that referenced
this pull request
May 6, 2022
## [v1.3.0](v1.2.1...v1.3.0) (2022-05-06) * update deps [#342](#342) ([Songmu](https://github.com/Songmu)) * use go install instead of go get [#337](#337) ([shogo82148](https://github.com/shogo82148)) * Simplify repository lock using sync.Map [#339](#339) ([itchyny](https://github.com/itchyny)) * bump Go 1.18 [#338](#338) ([shogo82148](https://github.com/shogo82148)) * bump the actions that run on Node.js 16 runtime [#336](#336) ([shogo82148](https://github.com/shogo82148)) * fix: [trivial] fix the error message if nothing is passed to `ghq create` [#334](#334) ([gfx](https://github.com/gfx)) * feat: do a bare clone [#328](#328) ([helmecke](https://github.com/helmecke)) * update installation go [#327](#327) ([isanasan](https://github.com/isanasan)) * avoid using "Japanese Only" [#325](#325) ([shogo82148](https://github.com/shogo82148))
|
Thank you! |
YuriSalesquw
added a commit
to YuriSalesquw/ghq
that referenced
this pull request
Dec 26, 2022
## [v1.3.0](x-motemen/ghq@v1.2.1...v1.3.0) (2022-05-06) * update deps [#342](x-motemen/ghq#342) ([Songmu](https://github.com/Songmu)) * use go install instead of go get [#337](x-motemen/ghq#337) ([shogo82148](https://github.com/shogo82148)) * Simplify repository lock using sync.Map [#339](x-motemen/ghq#339) ([itchyny](https://github.com/itchyny)) * bump Go 1.18 [#338](x-motemen/ghq#338) ([shogo82148](https://github.com/shogo82148)) * bump the actions that run on Node.js 16 runtime [#336](x-motemen/ghq#336) ([shogo82148](https://github.com/shogo82148)) * fix: [trivial] fix the error message if nothing is passed to `ghq create` [#334](x-motemen/ghq#334) ([gfx](https://github.com/gfx)) * feat: do a bare clone [#328](x-motemen/ghq#328) ([helmecke](https://github.com/helmecke)) * update installation go [#327](x-motemen/ghq#327) ([isanasan](https://github.com/isanasan)) * avoid using "Japanese Only" [#325](x-motemen/ghq#325) ([shogo82148](https://github.com/shogo82148))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior and error message on
ghq create(with no args) doesn't make sense. I've never seen that message before, in fact, but found it in making the pull-req #333.before:
after: