Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable relative path ssh URL #378

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Conversation

JyJyJcr
Copy link
Contributor

@JyJyJcr JyJyJcr commented Apr 2, 2024

Enable relative path in SCP style URL if the host is not github.com. This allows to specify the ssh repository by shorter URL, like http ones.

@Songmu
Copy link
Member

Songmu commented Apr 4, 2024

Thank you. We are having trouble with this URL style, especially since there is no clear specification. Maybe this change won't be a big problem, so I would like to merge it. Please fix the typo in the documentation beforehand.

@JyJyJcr
Copy link
Contributor Author

JyJyJcr commented Apr 4, 2024

Typo fixed. Thank you for reviewing!

@Songmu Songmu merged commit 8fefd96 into x-motemen:master Apr 4, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
@Songmu
Copy link
Member

Songmu commented Apr 10, 2024

Thank you for your contribution.
Considering the large implementation differences in SSH and git servers and the impact on the existing environment, I will revert this change.
I thought I should treat only GitHub especially, but Gitlab has the same problem, and in some cases, GitHub Enterprise is using GitHub on a custom domain.

@JyJyJcr
Copy link
Contributor Author

JyJyJcr commented Apr 10, 2024

I understood the problem. Thank you for your notice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants