-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QR code tag #41
Comments
Basically all they need to do is wrap this JS lib up and have the tag refresh when its innerHTML changes: http://davidshimjs.github.io/qrcodejs/ |
That sounds like something I could do. Can I take this task? |
Heck yes! We'd love to have you contribute. I'll send you a developer best
|
Awesome! Looking forward to see that guide. I have a question though. Should we use innerHTML as the link or define an attribute such as Another potential issue with using However, maybe there are appealing reasons for using the |
@arasbm here's the guide we've been developing in partnership with the Google folks: https://docs.google.com/document/d/1lbWrU0qsGMijDwzYNttUw352lUhfU7DJW4yxA_A8hq4/edit?usp=sharing As for this tag, the right move here is to use
|
Nice work drafting this, guys! |
@csuwildcat ok that make sense,
I tested it by selecting the element and changing its Thanks for the guide by the way, it is very useful. |
just an update that I have started implementing this tag here: https://github.com/arasbm/x-qr I have not been able to figure out a reasonable way to use the
the code is generated from the @fwenzel thanks for this awesome idea by the way! |
The addObserver() method takes 3 parameters: element, activity, and
|
I think passing the attributes straight down works, unless the tag has options of its own that you don't want to pass, but you could always handle those first and then pass on the rest of the bunch. As for text="...", that's the only thing I'd change by instead using the text content of the tag. Finally, sane defaults are key; |
Attributes are fine for the options, but the tag content (innerHTML) needs To observe these elements you would do: On Mon, Oct 21, 2013 at 9:59 AM, Fred Wenzel notifications@github.comwrote:
|
I didn't think that putting HTML in the body was a very likely use case On Mon, Oct 21, 2013 at 10:23 AM, Daniel Buchner
|
vcards are not actually HTML though? It's a plain text format? |
thanks for all the feedback! I am travelling today, but i will give this another shot tomorrow with |
@fwenzel I was looking at the xCard, but also thinking about xml data. |
I managed to change the code to use innerHTML. The remaining options are set by attributes. Feel free to checkout the code. Any suggestion/feature request please feel free to open an issue.
This is my first x-tag, so any advice will be highly appreciated :) |
I'd like to move this off of the Core repo, as it is not a library issue/bug. |
QR codes are everywhere (though their UX is questionable). It would be splendid to have a tag:
<x-qr>http://mozilla.org</x-qr>
and it appears.
That would also enable QR codes to be accessible. How hot is that.
The text was updated successfully, but these errors were encountered: