-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for helpers methods #519
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicksp
requested changes
Apr 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's clean up a little bit.
nicksp
reviewed
Apr 19, 2020
kararade
force-pushed
the
CLEANUP-2017-helpers-unit-tests
branch
2 times, most recently
from
April 21, 2020 17:00
3f01e4e
to
51fccae
Compare
kararade
force-pushed
the
CLEANUP-2017-helpers-unit-tests
branch
from
April 21, 2020 17:08
51fccae
to
2b0ddac
Compare
…p-ui into CLEANUP-2017-helpers-unit-tests
…elpers-unit-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Type: Dev Improvement
Fixes https://github.com/x-team/xp/issues/2017
Description
Unit tests added for the helper methods of XP-UI
Checklist
Before submitting a pull request, please make sure the following is done:
In Review
orIn Progress
depending on its status)npm run lint
)npm run flow
)npm run jest
) (NOTE: This is temporarily disabled. Skip it.)npm run build
command and committed changed files to the branchSteps to Test or Reproduce
rm -r node_dependencies && npm i
npm run jest
Impacted Areas in Application
src/utils/helpers.js
- added comments and removed dead methodsgetOlderBrowserErrorKey()
- refactoredtimeSince()
- refactored_tests_/utils/helpers.spec.js
- created.jest/setupTests.js
- refactoredScreenshots
timeSince()
helper method refactored/src/components/ui/ActivityBar.js
/src/components/ui/Email.js
/src/components/ui/EmailFeed.js
/src/components/ui/Note.js
getOlderBrowserErrorKey()
helper method refactored/src/components/ui/ErrorBox.js