Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #3

Merged
merged 1 commit into from
Sep 1, 2019
Merged

Update dependencies #3

merged 1 commit into from
Sep 1, 2019

Conversation

florianl
Copy link
Contributor

@florianl florianl commented Jun 5, 2019

Due to a bigger code refactoring, the API has changed. This PR updates this code to use the latest version.

Signed-off-by: Lehner Florian dev@der-flo.net

Signed-off-by: Lehner Florian <dev@der-flo.net>
@x-way x-way merged commit 1635710 into x-way:master Sep 1, 2019
@x-way
Copy link
Owner

x-way commented Sep 1, 2019

Thanks for the contribution 🙂

@x-way
Copy link
Owner

x-way commented Sep 1, 2019

FYI: had to revert this again, as endianness issues caused that the interface indexes extraced from the NFLOG attributes were no longer correct (possibly also affects other attributes).

For examplea.InDev pointed to an interface index value of 33554432 (which is 0x02000000) instead of the expected 2 (0x00000002).

With the API from before the refactoring, the interface index values are correct.

@florianl
Copy link
Contributor Author

florianl commented Sep 2, 2019

Thanks for reporting this. Will open an issue on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants