Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Capstone Submodule #6

Closed
RadWolfie opened this issue Oct 30, 2020 · 4 comments · Fixed by #7
Closed

Update Capstone Submodule #6

RadWolfie opened this issue Oct 30, 2020 · 4 comments · Fixed by #7
Labels
enhancement New feature or request

Comments

@RadWolfie
Copy link
Contributor

Hi @x1nixmzeng, we need capstone submodule update to latest branch, aka commit capstone-engine/capstone@d71c95b. Reason for this is to able use CMake's install method. At this time, we're not able to use install method because of cstool's broken install method using CMAKE_BINARY_DIR instead of CMAKE_CURRENT_BINARY_DIR. It would be great to verify if it works as intended or make necessary changes to work with capstone.

P.S. I'm not able to verify it since I am not an expert with C# area nor with capstone.

@RadWolfie
Copy link
Contributor Author

Actually, capstone.pc is enforced into CMAKE_BINARY_DIR. I'm not sure how accurate this is being correct. It will still work for the install method anyway.

@x1nixmzeng
Copy link
Owner

Thanks for opening the issue, I will investigate what is needed to update it

@RadWolfie
Copy link
Contributor Author

Any update with this task?

x1nixmzeng added a commit that referenced this issue Dec 11, 2020
@x1nixmzeng
Copy link
Owner

I've pushed the branch support-cmake-install which updates capstone and removes the msvc project.

The capstone install project may need turning off as it probably ships with headers

x1nixmzeng added a commit that referenced this issue Dec 11, 2020
Note a number of capstone options needed to be force set
@x1nixmzeng x1nixmzeng added the enhancement New feature or request label Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants