Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: add '$(BUILDDIR)' creation in sf2 copy rules #22

Closed
wants to merge 1 commit into from
Closed

Makefile: add '$(BUILDDIR)' creation in sf2 copy rules #22

wants to merge 1 commit into from

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jul 2, 2022

Noticed missing target directory dependency as a build failure in
make --shuffle mode (added in https://savannah.gnu.org/bugs/index.php?62100):

cp -v sf2/Black_Pearl_4_LV2.sf2 build/Black_Pearl_4_LV2.sf2
'sf2/Black_Pearl_4_LV2.sf2' -> 'build/Black_Pearl_4_LV2.sf2'
cp: cannot create regular file 'build/Black_Pearl_4_LV2.sf2': No such file or directory
make: *** [Makefile:233: build/Black_Pearl_4_LV2.sf2] Error 1 shuffle=1656755041

The change adds directory creation command similar to most other rules.

Noticed missing target directory dependency as a build failure in
`make --shuffle` mode (added in https://savannah.gnu.org/bugs/index.php?62100):

    cp -v sf2/Black_Pearl_4_LV2.sf2 build/Black_Pearl_4_LV2.sf2
    'sf2/Black_Pearl_4_LV2.sf2' -> 'build/Black_Pearl_4_LV2.sf2'
    cp: cannot create regular file 'build/Black_Pearl_4_LV2.sf2': No such file or directory
    make: *** [Makefile:233: build/Black_Pearl_4_LV2.sf2] Error 1 shuffle=1656755041

The change adds directory creation command similar to most other rules.
@x42
Copy link
Owner

x42 commented Jul 2, 2022

Rebased and merged as v0.5.0-1 43df20d
Thanks!

@x42 x42 closed this Jul 2, 2022
@trofi trofi deleted the fix-parallel-build branch July 2, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants