Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic CMake build, definitions in header for Windows DLL symbol… #24

Closed
wants to merge 1 commit into from

Conversation

pixsperdavid
Copy link

… import/export.

@pixsperdavid
Copy link
Author

This still needs to have testing built and DLL versioning info added but it's a start, and makes integration with other CMake projects much easier.

@x42
Copy link
Owner

x42 commented Dec 2, 2016

I'm sorry, I won't add another build system.

I'd be more than happy to replace autotools with something else that offers the same features (cross-compile, library API/ABI versioning, standard compliance regarding environment and arguments) but cmake ain't it.

@x42
Copy link
Owner

x42 commented Dec 2, 2016

the libltc_API is potentially useful, can you split that out in a separate commit?

@pixsperdavid
Copy link
Author

My main reasoning for creating this is for integration with a larger project using a CMake build system. Additionally, autotools is basically unknown to most Windows/MSVC developers. I don't personally know of any other widely-used cross-platform build systems which can produce VS projects.

I'm happy to maintain a CMake-based build as a fork, perhaps you could add a link to my fork in the readme?

@x42
Copy link
Owner

x42 commented Dec 8, 2016

That's cool.

I'm sorry that I can't merge and maintain this upstream, but I will definitely add a link for those who are interested. That'd be https://github.com/impsnldavid/libltc ?

@pixsperdavid
Copy link
Author

Yeah that's right. Will update for 1.3.0 now.

@x42
Copy link
Owner

x42 commented Dec 23, 2016

Bummer I forgot to add that link I was pushing out 1.3 to meet the debian/stretch freeze.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants