Introduce buffers to deal with Rubberband's variable output length #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x42
reviewed
Jun 11, 2018
src/repitch.cc
Outdated
| const uint32_t pos = sb->read_pos; | ||
| if (pos < sb->write_pos && pos > sb->write_pos-len) { | ||
| const uint32_t d = len-(sb->write_pos-pos); | ||
| memcpy(dst+d, sb->data+pos, (len-d)*sizeof(float)); |
There was a problem hiding this comment.
Should the destination not be cleared from dst ... dst+d here?
memset (dst, 0, d * sizeof(float));
There was a problem hiding this comment.
Would make sense, yes. However I don't hear any difference in the sound. Does Ardour give the LV2 plugins cleared output buffers?
There was a problem hiding this comment.
by default Ardour/LV2 uses in-place. input-buffer == output buffer.
There's `retrieve_buffer` where Rubberband puts its stuff in and there's `ring_buffer` where we add `retrieve_buffer`'s content to. Finally we take as many samples we need from `ring_buffer` to the output buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's
retrieve_bufferwhere Rubberband puts its stuff in and there'sring_bufferwhere we addretrieve_buffer's content to. Finally we take asmany samples we need from
ring_bufferto the output buffer.