Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(macro): add more lint escapes to generated code #66

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

tenuous-guidance
Copy link
Contributor

Both confik and confk-macros crate will need version bumps.

@tenuous-guidance
Copy link
Contributor Author

Note that I do not quite understand where these are needed. What's I've done may be overkill and has almost certainly missed some things.

In one crate I've used, the no Debug warning came up for our enums but not our structs despite having the same allowance made for them and the same pub level. If I expand the macro and then pasted it in however, then the structs also produced warnings.

I believe this change should be sufficient for the selected warnings but there may be a better approach to this that I'm unaware of.

@robjtede robjtede merged commit dbdae8f into x52dev:main Dec 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants