feat: Upgrading Openapi to 3.1 spec #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, left as commented some lines which I am uncertain as to their purpose. Fix for broken lint: https://github.com/x52dev/oas3-rs/actions/runs/7040864177/job/19162510659
robjtede
requested changes
Nov 30, 2023
| #[derive(Clone, Debug, Deserialize, Serialize, PartialEq, Default)] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub enum ParamLoc { | ||
| #[default] |
There was a problem hiding this comment.
good change
but.... why is query the default? the spec doesn't seem to define this
| pub struct Parameter { | ||
| /// The name of the parameter. |
|
|
||
| #[serde(rename = "contentMediaType")] | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub content_media_type: Option<String>, |
There was a problem hiding this comment.
The value of this property MUST be a string, which MUST be a media type
might be worth making this a mime::Mime
|
Some efforts have been made to better align with v3.1. As such this PR is outdated, feel free to re-open with a new base on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
I was having to parse a 3.1 json and noticed that some of the structures hadn't been updated yet.
The documents I used were:
Aside from that, I also removed the .vscode folder, rustfmt.toml and watch.sh, as suggestions.
The vscode folder I reckon could maybe be put in the gitignore.
The rustfmt one is all commented, but I don't know if it needs to be there for some CI flow.
And the watch.sh, could also be added to gitignore.
But then again, it's just a suggestion to make it more simple for contributions, but I really appreciate the effort in making it easier for people to run cargo watch or setup their environments.
ps.1: I'm not an experienced open-source contributor, so feel free to ask for as many changes as you want☺️
ps.2: Thanks for the project, it's been really useful!