Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XCDATAccessor class #222

Merged
merged 6 commits into from
Apr 19, 2022
Merged

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Apr 14, 2022

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder added Priority: High breaking-change A breaking change, intended for a major release. labels Apr 14, 2022
@tomvothecoder tomvothecoder self-assigned this Apr 14, 2022
@tomvothecoder tomvothecoder marked this pull request as ready for review April 14, 2022 22:36
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #222 (47c3003) into main (1fdc8a9) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #222   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         8    -1     
  Lines          742       693   -49     
=========================================
- Hits           742       693   -49     
Impacted Files Coverage Δ
xcdat/__init__.py 100.00% <ø> (ø)
xcdat/utils.py 100.00% <ø> (ø)
xcdat/spatial.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c01b7d2...47c3003. Read the comment docs.

@tomvothecoder
Copy link
Collaborator Author

tomvothecoder commented Apr 14, 2022

Hey @pochedls and @jasonb5, I rolled out this update pretty quickly.

Not really much to review, just deleted some files, update the API docs main page, and renamed .spatial_avg() to .spatial(). Good to see if you have any thoughts though.

docs/api.rst Outdated Show resolved Hide resolved
@tomvothecoder tomvothecoder merged commit 68ce0ae into main Apr 19, 2022
@tomvothecoder tomvothecoder deleted the feature/218-remove-xcdat-accessor branch April 19, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change, intended for a major release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Consider removing the XCDATAccessor class to avoid redundancy
3 participants