-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update create_grid
args to improve usability
#507
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 1517 1562 +45
=========================================
+ Hits 1517 1562 +45
☔ View full report in Codecov by Sentry. |
create_grid
and add create_axis
utility
create_grid
and add create_axis
utilitycreate_grid
args to improve usability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jasonb5, here's my code review. Most of my suggestions are related to formatting, docstrings, and comments.
Once addressed, LGTM. Thanks!
Co-authored-by: Tom Vo <tomvothecoder@gmail.com>
Thanks for merging Jason. Others can test the updates from this PR in v0.6.0rc1. I'll release that today! |
Description
This PR updates the
create_grid
API to make it easier to use. Acreate_axis
utility function streamlines the creation of axes by generating a tuple of coordinates and coordinate bounds as xr.DataArray, This axis tuple can be passed intocreate_grid
.create_bounds
functioncreate_axis
functionx
,y
,z
, andattrs
arguments tocreate_grid
function**kwargs
forcreate_grid
functioncreate_grid
function #496Checklist
If applicable: