Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Mapping - # of effects shows the # including all the submodels #4056

Closed
derwin12 opened this issue Oct 16, 2023 · 1 comment
Closed

Comments

@derwin12
Copy link
Collaborator

derwin12 commented Oct 16, 2023

When importing a sequence the # of effects is showing the total number including all the submodels. It also shows all the submodels and their totals. This is misleading. The # for the main model should just be the number of effects on that model itself.

Eg. Showstopper Snowflake might show 10 - you go and map that and nothing appears on your sequence. Turns out all the effects are on the submodels which were did NOT mapped over :-(

@derwin12
Copy link
Collaborator Author

Devs - I chased this down to SeqFileUtilities.cpp line 1253 during Import XLights procedure.
It calls int Element::GetEffectCount() const which sums all the effects on models+subs+strands
Can this be coded with some C++ trickery, to go to this function?
int Element::GetEffectCount() const which only counts effects on the actual model.
I did some crude testing, and I dont see any downside to showing this effect count but I cant figure out how to modify the code.
I could create a 3rd function but that seems like overkill when it is right there..

Thoughts? Even if the change isn't acceptable, how would this be done?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant