You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When importing a sequence the # of effects is showing the total number including all the submodels. It also shows all the submodels and their totals. This is misleading. The # for the main model should just be the number of effects on that model itself.
Eg. Showstopper Snowflake might show 10 - you go and map that and nothing appears on your sequence. Turns out all the effects are on the submodels which were did NOT mapped over :-(
The text was updated successfully, but these errors were encountered:
Devs - I chased this down to SeqFileUtilities.cpp line 1253 during Import XLights procedure.
It calls int Element::GetEffectCount() const which sums all the effects on models+subs+strands
Can this be coded with some C++ trickery, to go to this function? int Element::GetEffectCount() const which only counts effects on the actual model.
I did some crude testing, and I dont see any downside to showing this effect count but I cant figure out how to modify the code.
I could create a 3rd function but that seems like overkill when it is right there..
Thoughts? Even if the change isn't acceptable, how would this be done?
derwin12
added a commit
to derwin12/xLights
that referenced
this issue
Jan 25, 2024
When importing a sequence the # of effects is showing the total number including all the submodels. It also shows all the submodels and their totals. This is misleading. The # for the main model should just be the number of effects on that model itself.
Eg. Showstopper Snowflake might show 10 - you go and map that and nothing appears on your sequence. Turns out all the effects are on the submodels which were did NOT mapped over :-(
The text was updated successfully, but these errors were encountered: