Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login using email and case-insensitive username added #43

Closed
wants to merge 1 commit into from

Conversation

pratapaditya1997
Copy link

#40
I made this flow on top of your existing CheckLogin flow so that it will never break your existing code. I have kept the code as generic as possible. I tested this on my local and it worked fine. Please check on your end too

@xalanq
Copy link
Owner

xalanq commented Oct 6, 2019

I think it's too complicated. There is a simpler way to do that.

match, err := regexp.Match(fmt.Sprintf(`handle = "%v"`, username), body)

=>

match, err := regexp.Match(fmt.Sprintf(`(?i)handle = "%v"`, username), body)

https://stackoverflow.com/questions/15326421/how-do-i-do-a-case-insensitive-regular-expression-in-go

@pratapaditya1997
Copy link
Author

I don't think it will work while logging in with the user email which is also a requirement.

@xalanq
Copy link
Owner

xalanq commented Feb 27, 2020

Thanks for your work! I'll handler it on this weekend or next weekend.

@xalanq
Copy link
Owner

xalanq commented Feb 27, 2020

Fix it by

match, err := regexp.Match(`handle = "[\s\S]+?"`, body)

@xalanq xalanq closed this Feb 27, 2020
@xalanq xalanq mentioned this pull request Feb 27, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants