-
Notifications
You must be signed in to change notification settings - Fork 505
PhoneDialer API's #25
Comments
As for me it can be simplified: static class PhoneDialer
{
static bool CanOpenDialer { get; }
static void OpenDialer(string number);
static void OpenDialer(string number, string name);
} Just a few moments to clarify:
|
Thanks for your feedback. I am really agreeing with you here. With regards to the methods, we would like to avoid the default parameters as this may make it harder to change in future. |
I am thinking that in the Platform we can have "capabilities" instead of each API having a "can do this" static class Capabilities
use:
I don't know if we need a name option as I don't think that is handled gracefully. We should also avoid duplicating words if it is in the class name. |
I think we should move this (Capabilities) discussion to #17 - I have a longer comment there |
I removed the name parameter as it is just supported on UWP right now. However, if this is a cool feature, we could probably just add it to the UWP version: class Dialer {
#if UWP
void Open(string number, string name);
#endif
void Open(string number);
} This way we get a nice feature, but do not add it to the cross-platform API where it is not supported. |
I think eventually we may add this sort of thing in, but let's stick to things that work everywhere for the most part for now. |
* added phone dialer api * fixes according to comments * Merge branch 'master' into feature/phone-dialer * Added the UWP SDK references and fix the Android intent logic as StartNewActivity does not exist. * fixed style errors * added phone dialer sample * added phone dialer tests
* GH-25: Add PhoneDialer API (#37) * added phone dialer api * fixes according to comments * Merge branch 'master' into feature/phone-dialer * Added the UWP SDK references and fix the Android intent logic as StartNewActivity does not exist. * fixed style errors * added phone dialer sample * added phone dialer tests * Cleanup exceptions from merge * Cleanup dial API and is supported * Cleanup dialers is supported * Cleanup tests and samples. * Add phone dialer docs. * Cleanup UWP * Add remarks * Changes based on feedback to cleanup samples. * Add platform helpers.
A simple API to open the default dialer, preloaded with a number and name.
For the discussion around exceptions, see #19
The text was updated successfully, but these errors were encountered: