This repository has been archived by the owner on May 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 505
Geolocation API's #7
Comments
Maybe we should split this issue into two separate to focus the discussion and implementation. |
Geocoder should have it's own thread as it is a different api |
Closed
Moved Geocoding to #28. |
There was a comment (#29 (comment)) that suggested that we change the Also, all the stuff already starts with the Any thoughts? |
jamesmontemagno
added
in-progress
Actively being worked on.
and removed
enhancement
labels
Mar 29, 2018
jamesmontemagno
pushed a commit
that referenced
this issue
Apr 10, 2018
* First pass at Android Geolocation impl * No need for nullables * Added the geolocation sample * Added the UWP geolocation implementation * Getting some of the iOS in * Use a global location manager so that the permissions popup lives for mor than a few seconds * Check before asking on iOS * Finished the iOS implementation and tweak a few things * Remove the unsused using * Don't use locking and static fields, use the TCS state * Keep the manager alive for the duration of the method * Use platform specific accuracy * Moving files after merge * Changing namespaces * Removed the `ConfigureAwait(false)` instances * Use extension methods * tabs not spaces * Added sopme docs * More docs * Added some tests (that can't run yet) * Enabling the tests for CI after adding attributes * Added the iOS permissions text to the tests * iOS has opinions when it comes to locations * Starting the location manager on the main thread, but return on the original thread * We just need to call the constructor in the main thread * Added all the permissions to the manifest for the samples and the tests * Android has looper issues * Location is now a declared permission * Changes based on feedback. * Cleanup iOS Permissions. Must have static location manager around. * The stylish copper got us again
sung-su
pushed a commit
to sung-su/Essentials
that referenced
this issue
Nov 26, 2019
Update MainThread.shared.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The Geolocation API is meant to be extremely simple at this point.
Geocoding API's: #28
The accuracy enum values should map to the following table of platform specific accuracy choices:
The text was updated successfully, but these errors were encountered: