Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Fixes #1729 check for ios 13 on max frame rates #1731

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Conversation

jamesmontemagno
Copy link
Collaborator

Description of Change

Describe your changes here.

Bugs Fixed

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

List all API changes here (or just put None), example:

Added:

  • string Class.Property { get; set; }
  • void Class.Method();

Changed:

  • object Cell.OldPropertyName => object Cell.NewPropertyName

If there is an entirely new API, then you can use a more verbose style:

public static class NewClass {
    public static int SomeProperty { get; set; }
    public static void SomeMethod(string value);
}

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@jamesmontemagno
Copy link
Collaborator Author

Ready @mattleibow

@jamesmontemagno jamesmontemagno added the ready-to-merge Review completed, Ready for API review and merge label Apr 12, 2021
@jamesmontemagno jamesmontemagno added this to the 1.7.0 milestone Jun 9, 2021
Copy link
Contributor

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 is probably not the greatest value, but we do that for Android so better to be consistent where 0 == unknown.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-to-merge Review completed, Ready for API review and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants