Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Add synchronous API for SecureStorage: Get / Set #857

Closed
wants to merge 5 commits into from

Conversation

scotru
Copy link

@scotru scotru commented Jul 22, 2019

Description of Change

SecureStorage provides async APIs for getting and setting values: SetAsync/GetAsync. This PR adds a synchronous API on iOS and Android: Set/Get for users who may not want the async wrapping.

Bugs Fixed

None

API Changes

Added:

  • public static string SecureStorage.Get(string key)
  • public static void SecureStorage.Set(string key, string value)

Changed:

In some cases, the platform specific async APIs are converted to wrappers around the new synchronous APIs.

Behavioral Changes

Should be fully backwards compatible.

@msftclas
Copy link

msftclas commented Jul 22, 2019

CLA assistant check
All CLA requirements met.

@VSC-Service-Account
Copy link

Docs Build status updates of commit 3c3fdb7:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/SecureStorage/SecureStorage.android.cs ✅Succeeded
Xamarin.Essentials/SecureStorage/SecureStorage.ios.cs ✅Succeeded
Xamarin.Essentials/SecureStorage/SecureStorage.netstandard.cs ✅Succeeded
Xamarin.Essentials/SecureStorage/SecureStorage.shared.cs ✅Succeeded
Xamarin.Essentials/SecureStorage/SecureStorage.uwp.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@VSC-Service-Account
Copy link

Docs Build status updates of commit 45a8dbf:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/SecureStorage/SecureStorage.android.cs ✅Succeeded
Xamarin.Essentials/SecureStorage/SecureStorage.ios.cs ✅Succeeded
Xamarin.Essentials/SecureStorage/SecureStorage.netstandard.cs ✅Succeeded
Xamarin.Essentials/SecureStorage/SecureStorage.shared.cs ✅Succeeded
Xamarin.Essentials/SecureStorage/SecureStorage.uwp.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@VSC-Service-Account
Copy link

Docs Build status updates of commit 37de2c1:

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/SecureStorage/SecureStorage.android.cs ✅Succeeded
Xamarin.Essentials/SecureStorage/SecureStorage.ios.cs ✅Succeeded
Xamarin.Essentials/SecureStorage/SecureStorage.netstandard.cs ✅Succeeded
Xamarin.Essentials/SecureStorage/SecureStorage.shared.cs ✅Succeeded
Xamarin.Essentials/SecureStorage/SecureStorage.uwp.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@jamesmontemagno
Copy link
Collaborator

Thank you so much for the pull request and for opening the issue. Please see my feedback: #856

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants