[IMPROVEMENT] Nuget Readme included in the package #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/GooglePlayServicesComponents into mu-20231001-nuget-readme
jpobst
reviewed
Oct 30, 2023
|
|
||
| Google.Play.Services, Firebase and ML Kit (GPS-FB-MLKit) Bindings NuGet Package @(Model.NuGetPackageId) | ||
|
|
||
| .NET for Android (formerly Xamarin.Android) GPS-FB-MLKit bindings NuGet Package @(Model.NuGetPackageId) |
There was a problem hiding this comment.
The name they finally decided on is .NET Android.
jpobst
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this change any of the generated binding API's?
No.
Describe your contribution
NuGet best practices recommend adding
readme.[txt,md]to each package. Otherwise following warning is emitted:This PR adds
readme.mdto NuGet packages.https://devblogs.microsoft.com/nuget/add-a-readme-to-your-nuget-package/
https://devblogs.microsoft.com/nuget/write-a-high-quality-readme-for-nuget-packages/
NuGet/Home#12070
https://raw.githubusercontent.com/lyndaidaii/NuGetReadMeTemplate/main/README.md
Verification
Result: