Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Referencing Xamarin Forms Nuget breaks Tizen CarouselPage renderer #12451

Closed
DamianMehers opened this issue Oct 11, 2020 · 4 comments · Fixed by #12479
Closed

[Bug] Referencing Xamarin Forms Nuget breaks Tizen CarouselPage renderer #12451

DamianMehers opened this issue Oct 11, 2020 · 4 comments · Fixed by #12479
Assignees
Labels
p/Tizen s/unverified New report that has yet to be verified t/bug 🐛

Comments

@DamianMehers
Copy link

DamianMehers commented Oct 11, 2020

Description

In my app, I have the following Projects:

  • MyApp.Forms - contains all cross-platform Forms code, and references Xamarin.Forms
  • MyApp.Tizen - contains Tizen-Specific Forms code, and references MyApp.Forms, Tizen.NET and Tizen.Wearable.CircularUI
  • MyApp.iOS - contains iOS code, and references MyApp.Forms
  • MyApp.Android- contains Androidcode, and references MyApp.Forms

I share my Forms code across all the platforms. This structure breaks the rendering of the CarouselPage on Tizen.

The CarouselPage does not render properly when the Tizen Project references the Xamarin.Forms Nuget, either directly or indirectly (such as via the MyApp.Forms project above).

Steps to Reproduce

  1. Create a new Tizen Forms wearable project (api version 4)
  2. In your App.xaml.cs replace the main page assignment with MainPage = new NavigationPage(new CarouselPage { Title = "hello", BackgroundColor = Color.Orange });
  3. Run the app - the orange background is displayed
  4. Update the app to reference the standard Xamarin Forms Nuget.
  5. Run the app - the orange background is NOT displayed. Rendering is broken

This is a simple example, but it seems to me that rendering is totally broken in that pages added to the CarouselPage don't display at all.

Expected Behavior

I expect to be able to put my shared Xamarin Forms code in its own project, which references the Xamarin Forms Nuget, and have a separate Tizen-Specific project which references the shared project,

Actual Behavior

Referencing the Xamarin Forms Nuget either directly, or indirectly breaks rendering of the CarouselPage

Basic Information

  • Visual Studio Tools for Tizen 3.1.0.0
  • Tizen.NET.Sdk/1.0.9
  • Xamarin.Forms 4.8.0.1534
  • Tizen.Wearable.CircularUI 1.5.2
  • Visual Studio About: version.txt

Reproduction Link

TestTizenCarouselPage.zip

@DamianMehers DamianMehers added s/unverified New report that has yet to be verified t/bug 🐛 labels Oct 11, 2020
@rookiejava rookiejava self-assigned this Oct 13, 2020
@rookiejava
Copy link
Collaborator

Hi @DamianMehers, thank you for reporting issue. Let me check!

@rookiejava
Copy link
Collaborator

When I checked with the test project you attached, I confirmed that the problem was caused by the side effect of #11824. Since this PR has been applied from 4.8.0.1364, it is recommended to use version 4.8.0.1269 or lower until it is modified.

As you can see below, 4.8.0.1269 works well (both mobile and wearable). Thanks.

@DamianMehers
Copy link
Author

Great, thanks I'll try it out. Not sure yet if the that CarouselPageRenderer depends on internals, but if not perhaps I can compile and register it in the current version.

@rookiejava
Copy link
Collaborator

Will submit a patch soon. 😉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p/Tizen s/unverified New report that has yet to be verified t/bug 🐛
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants