-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Bug] Crash in iOS's EntryRenderer due to "NSRangeException Reason: Cannot remove an observer ... for the key path "sublayers" from <CALayer 0x600007b11e80> because it is not registered as an observer still present in SR7 #14887
Comments
@jfversluis The saga continues :( Given the amount of people reporting this issue since the original changes were released, and the difficulty in fixing it without breaking other stuff, is it worth simply reverting the original changes from PR #14526? I'd personally rather live with an untinted clear button than a crashing app but it's not my call to make :) You can see what these changes were trying to resolve in @rotorgames's comment here - #14566 (comment) |
It's very strange, I think you confirmed it working in an earlier build right? So I don't see how it broke in the meanwhile, since nothing happened. I agree with you that I think I'll just revert the initial change and be done with it. This is doing more wrong than good :) |
I did test the PR build and it was working for the original report so all seemed good. What I'm seeing now is the same crash in a different part of the app which I was blocked from reaching before which is just weird. I really don't understand how it was fixed in one place but not another, but then again I didn't understand how the changes fixed the original problem so what do I know! :D |
We are having the same problem (not 100% sure since what exact version it's been happening, since I do my initial dev on android first) but we are not even using the clear button on the entry boxes, I looks like its always happens when navigating back from a page. |
After some more testing this issue started occurring after 5.0.0.2125 (both 5.0.0.2196 & 5.0.0.2244), it's very consistent and crashing pretty much on every page in iOS with entry boxes on them (only had time to test iPhone 8 iOS 13.7 simulator). It almost look when it's trying to navigating back to a form that has an entry box on it, and it doesn't matter what the ClearButtonVisibility is set to. Included the stack trace if it helps
|
Yes this is still active even on latest XF version 5.0.0.2244, please we need a fix for this issue ASAP. |
Hey all, so sorry about this, I'm looking to revert the initial changed that caused all this. I will do that tomorrow. cc: @rotorgames |
OK, did it now. If the build finishes on that PR, could you all grab the version as per the instructions here and let us know if this fixes this issue? Make sure to get the EXACT version from that PR, as this change will not be in any of the other versions. Also have an extensive play with it to see if this fixes it for every scenario. @lee-m I see you have a repro for the original issue, I might have another play with that and see if I can put in a fix, even if it's a try/catch or something, for the initial issue as well |
My original issue from way back with the null reference exception was fixed by the "if (image == null)" check in GetClearButtonTintImage and should still be OK as far as I can tell. |
@jfversluis thanks for your quick response, I've tested PR build 7844 and it fixes our crashing on iOS issue. As this PR is a revert from your part I can't say what it did to initial issue this was originally trying to fix, but at least the iOS crashing is not present anymore. We will revert to 5.0.0.2125 for the time being until this is released. Thanks again for your help. |
Perfect. It seems that the only thing not working then is indeed the tinting? I can live with that, especially only for older iOS versions which are not very widely used anymore.
Sure thing! Sorry this happened :) should be all good then for the next release! |
Yep. It's just the tinting which is wonky now. Who'd have thought trying to tint a button could cause so much trouble 😄 |
You won't believe the number of simple issues I've seen that turn out to be the hardest ones 😅 |
Hi, Are we going to need to wait for SR8 in Dec for this? This NRE has been present in last two releases (SR6 and SR7). This is a huge problem for us as we are blocked from using SR5 by CollectionView issues fixed in SR6 and SR7 so can't rollback to SR5 without causing even more issues. |
@guestiapaul I'm afraid so. I'll see what I can do. In the meantime can you confirm that the nightly version indeed fixes the NRE for you? |
@jfversluis - tested and working in Build #5.0.0.7844+0-pr.14893. In the meantime, we've been left with no choice but to revert to 5.0.0.2125. This regression must be affecting a large number of apps so anything you can do before SR8 would be appreciated. |
While not ideal, you can use the nightly feed. That version should build every night (if there are changes) and should ultimately lead up to the next service release version. That one will also have this fix, probably tomorrow because I think I merged it today. You could use that in the meanwhile. |
@jfversluis Are there any news when this bug fix will be released? We are waiting for this for our next app release .. and no, I will not use this pre build 5.0.0.7844 for our final app release |
@preitzel The next release is planned for around Dec. 15th as you can follow here by our project boards: https://github.com/xamarin/Xamarin.Forms/projects |
Still happening in XF 5.0.0.2244 |
@xleon as pointed out, next release it will be fixed. You can try the nightly today to confirm |
See #14804 for more info where this was originally reported.
Unfortunately, the changes in SR7 that added and rejigged the fix for this still hasn't fully fixed the problem and I'm still seeing this crash, albeit in a different place to where it was occurring when I logged #14804 so opening a new issue for this since the original was closed.
The text was updated successfully, but these errors were encountered: