Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

AutomationProperties.Name, AutomationProperties.HelpText on Button not read by Android TalkBack #5150

Closed
ryl opened this issue Feb 6, 2019 · 0 comments · Fixed by #13244
Closed

AutomationProperties.Name, AutomationProperties.HelpText on Button not read by Android TalkBack #5150

ryl opened this issue Feb 6, 2019 · 0 comments · Fixed by #13244
Assignees
@samhouts
Labels
a/a11y 🔍 help wanted We welcome community contributions to any issue, but these might be a good place to start! in-progress This issue has an associated pull request that may resolve it! inactive Issue is older than 6 months and needs to be retested p/Android t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!

Comments

@ryl
Copy link
Contributor

ryl commented Feb 6, 2019 •
edited
Loading

Description

AutomationProperties.Name and AutomationProperties.HelpText are not read by TalkBack on Android when placed on a Button element.

Steps to Reproduce

  1. SetText property on a button.
  2. Add AutomationProperties.Name and AutomationProperties.HelpText values to button.
  3. Enable TalkBack through Android Settings.
  4. Navigate to button, notice neither Name, nor HelpText are read.

Expected Behavior

I expect an experience more similar to iOS.

Text is not null, Name is Null, HelpText is not null
"Text. HelpText" is read by TalkBack

Text is not null, Name is Not Null, HelpText is not null
"Name. HelpText" is read by TalkBack

Actual Behavior

Name and HelpText are not read when Text is set.

Basic Information

  • Version with issue: 3.4, 3.5
  • Last known good version: n/a
  • IDE: Visual Studio 2017 Professional Mac
  • Platform Target Frameworks:
    • Android: Android SDK 9.0
  • Android Support Library Version:
  • Nuget Packages: none
  • Affected Devices: Any android device it seems.
@ryl ryl added the t/bug 🐛 label Feb 6, 2019
@ryl ryl mentioned this issue Feb 13, 2019
Closed
3 tasks
@samhouts samhouts added inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! labels Aug 6, 2019
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Oct 18, 2019
@samhouts samhouts added inactive Issue is older than 6 months and needs to be retested and removed inactive Issue is older than 6 months and needs to be retested labels Jan 14, 2020
@ryl ryl mentioned this issue Feb 26, 2020
Closed
3 tasks
@samhouts samhouts removed help wanted We welcome community contributions to any issue, but these might be a good place to start! inactive Issue is older than 6 months and needs to be retested up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! labels Feb 28, 2020
@samhouts samhouts self-assigned this Feb 28, 2020
@samhouts samhouts added inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! labels Mar 2, 2020
@samhouts samhouts added the up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! label Mar 2, 2020
@samhouts samhouts added this to the 5.0.0 milestone Aug 13, 2020
@samhouts samhouts removed this from the 5.0.0 milestone Nov 2, 2020
@PureWeen PureWeen mentioned this issue Dec 28, 2020
Merged
2 tasks
rmarinho pushed a commit that referenced this issue Dec 31, 2020
@PureWeen @ryl
[Android] TalkBack now reads name and helptext on buttons. (#13244) f…
75f9a3f 
…ixes #5150

* Read name and helptext without disrupting automation id.

* - Fix Merge

* - remove if/defs

* - fix Legacy Renderers

* - fix UI Test

* - fix invalid AutomationId with cell reuse

* - fix Container so it's not read by accessibility

Co-authored-by: Ry Lowry <rylowry@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@samhouts samhouts

Labels
a/a11y 🔍 help wanted We welcome community contributions to any issue, but these might be a good place to start! in-progress This issue has an associated pull request that may resolve it! inactive Issue is older than 6 months and needs to be retested p/Android t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Projects
None yet
Milestone
No milestone
2 participants
@ryl @samhouts