This repository has been archived by the owner on May 1, 2024. It is now read-only.
[WPF] Open DatePicker when control receives focus (to match other platforms) #11087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest Xamarin.Forms
…ncy with iOS/Android etc.
|
@peterfoot There is a small conflict, could you review it? |
jsuarezruiz
approved these changes
Jun 24, 2020
riverar
suggested changes
Aug 13, 2020
| @@ -1,12 +1,4 @@ | |||
| using System; | |||
| using System.Collections.Generic; | |||
| using System.ComponentModel; | |||
There was a problem hiding this comment.
Add using System;, required for Uri
Add using System.Windows.Media;, required for FontFamily
riverar
approved these changes
Aug 16, 2020
myroot
pushed a commit
to myroot/Xamarin.Forms
that referenced
this pull request
Aug 19, 2020
…tforms) (xamarin#11087) * Added automatic opening of the control on keyboard focus for consistency with iOS/Android etc. * Merged remote and fixed missing using statements Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> fixes xamarin#10358
sung-su
pushed a commit
to sung-su/Xamarin.Forms
that referenced
this pull request
Aug 20, 2020
…tforms) (xamarin#11087) * Added automatic opening of the control on keyboard focus for consistency with iOS/Android etc. * Merged remote and fixed missing using statements Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> fixes xamarin#10358
sung-su
pushed a commit
to sung-su/Xamarin.Forms
that referenced
this pull request
Aug 20, 2020
…tforms) (xamarin#11087) * Added automatic opening of the control on keyboard focus for consistency with iOS/Android etc. * Merged remote and fixed missing using statements Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> fixes xamarin#10358
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes consistency with other platforms. When the control receives keyboard focus open the dropdown.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
Previously the control would only open when user tapped on the calendar button. Now the control opens automatically when you call Focus() on it programmatically.
Before/After Screenshots
Not applicable
Testing Procedure
Use the control gallery app
Go to DatePicker Gallery
Select Focus test
Press the button to set focus to the DatePicker and observe the drop-down calendar is displayed
PR Checklist