Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] Pop when on second page and BackButton is replaced #11192

Merged
merged 1 commit into from
Jul 17, 2020
Merged

[iOS] Pop when on second page and BackButton is replaced #11192

merged 1 commit into from
Jul 17, 2020

Conversation

PureWeen
Copy link
Contributor

Description of Change

When the back button is being replaced it was always opening the flyout instead of navigating back when not on the root page

Issues Resolved

Platforms Affected

  • iOS

Testing Procedure

  • ui tests included
  • open the Back Button page and play around make sure it all acts as you'd expect

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Jun 25, 2020
@PureWeen
Copy link
Contributor Author

Test failures not related

@PureWeen PureWeen merged commit 9607f0e into 4.7.0 Jul 17, 2020
@PureWeen PureWeen deleted the fix_7856 branch July 17, 2020 02:45
@samhouts samhouts added this to the 4.7.0 milestone Jul 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samhouts samhouts samhouts approved these changes

@rmarinho rmarinho Awaiting requested review from rmarinho

Assignees

@rmarinho rmarinho

@samhouts samhouts

Labels
a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. p/iOS 🍎 t/bug 🐛
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@PureWeen @samhouts @rmarinho