[UWP] Remove Focus call when setting FormsTextBox Vertical Alignment #11350
Conversation
bmacombe
changed the title
samhouts
added
p/UWP
4.7.0
|
I looked at the failing UWP regression tests Bugzilla36171 ran fine locally both with manual verification and running the test |
|
Does |
|
@PureWeen Yeah, I ran both tests under 36171, just did them again for good measure.
Also I didn't look at the iOS test fails, I assume they aren't related |
|
Right! you said 36171 Sounds good. We're still working out the kinks on the automated CI runs of UWP :-) |
|
That will be great! I can get individual ones to run ok...on my desktop...but not on either a Surface Laptop 2 I had or 3 I have now, unless I switch out the SearchBar for Entry (first char in the search gets cut off with a SearchBar), then they work 😕 Except for some of the seemly random 'Currently selected window has been closed', timeouts, etc. |
|
@PureWeen Hope you take some time off this weekend! These test fixes come like clockwork! |
Can't sleep! Tests are failing.... :-p |
Description of Change
Removes call to Focus added in #11140 that caused regression #11348
#8787 should be reopened as it is no longer resolved with this change.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
Entry was getting focus when a page loaded and it should not be. This restores the original behavior.
Before/After Screenshots
Not applicable
Testing Procedure
Check issue pages 2172, 8503, 8222, and then Entry Gallery Focus page
PR Checklist